[PATCH 0/2] New flags for Fibre Channel over Ethernet (FCoE)

[PATCH 0/2] New flags for Fibre Channel over Ethernet (FCoE)

[Yi Zou]

Hi,
I am working on the Fibre Channel over Ethernet (FCoE) at open-fcoe.org and
would like to add the following new define/feature flogs in netdev for FCoE.

The first patch adds the protocol type as ETH_P_FCOE for FCoE protocol and the
second one adds offload feature flags for FCoE in netdev, which is based on
the earlier post: http://marc.info/?l=linux-netdev&m=122228979113312&w=2.

Thanks.

yi
---

Chris Leech (1):
      net: define feature flags for FCoE offloads

Yi Zou (1):
      net: add ETH_P_FCOE for Fibre Channel over Ethernet (FCoE)


 include/linux/if_ether.h  |    1 +
 include/linux/netdevice.h |    3 +++
 include/linux/skbuff.h    |    2 ++
 3 files changed, 6 insertions(+), 0 deletions(-)

-- 
Signature : Yi Zou <yi.zou-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

[PATCH 1/2] net: add ETH_P_FCOE for Fibre Channel over Ethernet (FCoE)

[Yi Zou]

Signed-off-by: Yi Zou <yi.zou-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---

 include/linux/if_ether.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
index 723a1c5..e225b41 100644
--- a/include/linux/if_ether.h
+++ b/include/linux/if_ether.h
@@ -77,6 +77,7 @@
 #define ETH_P_PAE	0x888E		/* Port Access Entity (IEEE 802.1X) */
 #define ETH_P_AOE	0x88A2		/* ATA over Ethernet		*/
 #define ETH_P_TIPC	0x88CA		/* TIPC 			*/
+#define ETH_P_FCOE      0x8906          /* Fibre Channel over Ethernet  */
 
 /*
  *	Non DIX types. Won't clash for 1500 types.

[PATCH 2/2] net: define feature flags for FCoE offloads

[Yi Zou]

From: Chris Leech <christopher.leech-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Signed-off-by: Chris Leech <christopher.leech-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Yi Zou <yi.zou-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---

 include/linux/netdevice.h |    3 +++
 include/linux/skbuff.h    |    2 ++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 9cfd20b..ef65927 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -522,6 +522,8 @@ struct net_device
 #define NETIF_F_NETNS_LOCAL	8192	/* Does not change network namespaces */
 #define NETIF_F_LRO		32768	/* large receive offload */
 
+#define NETIF_F_FCOE_CRC	(1 << 24) /* FCoE CRC32 */
+
 	/* Segmentation offload features */
 #define NETIF_F_GSO_SHIFT	16
 #define NETIF_F_GSO_MASK	0xffff0000
@@ -530,6 +532,7 @@ struct net_device
 #define NETIF_F_GSO_ROBUST	(SKB_GSO_DODGY << NETIF_F_GSO_SHIFT)
 #define NETIF_F_TSO_ECN		(SKB_GSO_TCP_ECN << NETIF_F_GSO_SHIFT)
 #define NETIF_F_TSO6		(SKB_GSO_TCPV6 << NETIF_F_GSO_SHIFT)
+#define NETIF_F_GSO_FCOE	(SKB_GSO_FCOE << NETIF_F_GSO_SHIFT)
 
 	/* List of features with software fallbacks. */
 #define NETIF_F_GSO_SOFTWARE	(NETIF_F_TSO | NETIF_F_TSO_ECN | NETIF_F_TSO6)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 720b688..be60560 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -188,6 +188,8 @@ enum {
 	SKB_GSO_TCP_ECN = 1 << 3,
 
 	SKB_GSO_TCPV6 = 1 << 4,
+
+	SKB_GSO_FCOE = 1 << 5,
 };
 
 #if BITS_PER_LONG > 32

Re: [PATCH 1/2] net: add ETH_P_FCOE for Fibre Channel over Ethernet (FCoE)

[Roland Dreier]

 >  #define ETH_P_AOE	0x88A2		/* ATA over Ethernet		*/
 >  #define ETH_P_TIPC	0x88CA		/* TIPC 			*/
 > +#define ETH_P_FCOE      0x8906          /* Fibre Channel over Ethernet  */

trivial -- but the patch format makes it pretty obvious -- it would
probably be nice to use tabs to align things on the FCOE line the same
way the other lines in the file do, rather than using spaces.

Re: [PATCH 2/2] net: define feature flags for FCoE offloads

[Ben Hutchings]

On Mon, 2008-10-06 at 15:09 -0700, Yi Zou wrote:
> From: Chris Leech <christopher.leech@intel.com>
> 
> Signed-off-by: Chris Leech <christopher.leech@intel.com>
> Signed-off-by: Yi Zou <yi.zou@intel.com>
> ---
> 
>  include/linux/netdevice.h |    3 +++
>  include/linux/skbuff.h    |    2 ++
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 9cfd20b..ef65927 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -522,6 +522,8 @@ struct net_device
>  #define NETIF_F_NETNS_LOCAL	8192	/* Does not change network namespaces */
>  #define NETIF_F_LRO		32768	/* large receive offload */
>  
> +#define NETIF_F_FCOE_CRC	(1 << 24) /* FCoE CRC32 */
> +
>  	/* Segmentation offload features */
>  #define NETIF_F_GSO_SHIFT	16
>  #define NETIF_F_GSO_MASK	0xffff0000
[...]

NETIF_F_FCOE_CRC shouldn't be included in NETIF_F_GSO_MASK.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

RE: [PATCH 1/2] net: add ETH_P_FCOE for Fibre Channel over Ethernet (FCoE)

[Zou, Yi]

> >  #define ETH_P_TIPC	0x88CA		/* TIPC
*/
> > +#define ETH_P_FCOE      0x8906          /* Fibre Channel over
Ethernet
>*/
>
>trivial -- but the patch format makes it pretty obvious -- it would
>probably be nice to use tabs to align things on the FCOE line the same
>way the other lines in the file do, rather than using spaces.

Thanks, will fix this and resubmit.

yi

RE: [PATCH 2/2] net: define feature flags for FCoE offloads

[Zou, Yi]

>>
>> +#define NETIF_F_FCOE_CRC	(1 << 24) /* FCoE CRC32 */
>> +
>>  	/* Segmentation offload features */
>>  #define NETIF_F_GSO_SHIFT	16
>>  #define NETIF_F_GSO_MASK	0xffff0000
>[...]
>
>NETIF_F_FCOE_CRC shouldn't be included in NETIF_F_GSO_MASK.
>
>Ben.
>
I apologize for this patch as one patch to claim the a few bits back
from SKB_GSO_MASK was missing here in the original series. I shall
resubmit the complete series to have all patches included, plus fixing
the style issue in the first patch. 

Thanks.

yi