From: Roland Dreier <rdreier@cisco.com>
To: Andrew Gallatin <gallatin@myri.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
davem@davemloft.net, ossthema@de.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH]: fix lro_gen_skb() alignment
Date: Fri, 30 Nov 2007 11:14:43 -0800 [thread overview]
Message-ID: <ada3aunlf4s.fsf@cisco.com> (raw)
In-Reply-To: <475057E4.3000909@myri.com> (Andrew Gallatin's message of "Fri, 30 Nov 2007 13:35:16 -0500")
> >> - skb = netdev_alloc_skb(lro_mgr->dev, hlen);
> >> + skb = netdev_alloc_skb(lro_mgr->dev, hlen + NET_IP_ALIGN);
> > NET_IP_ALIGN should only be used if you're DMAing into the skb head.
> > Otherwise you should say 2. It would be nice to have another macro
> > for that I suppose.
>
> It is certainly simple enough to say 2. Thank you for pointing
> this out. I have attached a patch to do that..
>
> Signed off by: Andrew Gallatin <gallatin@myri.com>
Isn't the value of 2 ethernet-specific (to round the 14-byte header up
to 16)? Given that the rest of the lro code is fairly careful to
calculate mac_hdr_len etc it seems as if it would be cleaner to make
this independent of the specific L2 being used.
(And I plan on using the LRO module for IP-over-InfiniBand so this is
not completely theoretical)
- R.
next prev parent reply other threads:[~2007-11-30 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 14:47 [PATCH]: fix lro_gen_skb() alignment Andrew Gallatin
2007-11-30 9:59 ` Herbert Xu
2007-11-30 18:35 ` Andrew Gallatin
2007-11-30 19:14 ` Roland Dreier [this message]
2007-11-30 19:35 ` Andrew Gallatin
2007-11-30 22:34 ` Herbert Xu
2007-12-03 0:07 ` Andrew Gallatin
2007-12-03 9:29 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada3aunlf4s.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).