From: Roland Dreier <rdreier@cisco.com>
To: Moni Shoua <monis@voltaire.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
jeff@garzik.org, David Miller <davem@davemloft.net>,
ogerlitz@voltaire.com, netdev@vger.kernel.org,
Moni Levy <monil@voltaire.com>
Subject: Re: [PATCH] IB/ipoib: Bound the net device to the ipoib_neigh structue
Date: Thu, 11 Oct 2007 13:17:39 -0700 [thread overview]
Message-ID: <ada3awhcsnw.fsf@cisco.com> (raw)
In-Reply-To: <470E37AD.3070408@voltaire.com> (Moni Shoua's message of "Thu, 11 Oct 2007 16:48:13 +0200")
> It happens only when ib interfaces are slaves of a bonding device.
> I thought before that the stuck is in napi_disable() but it's almost right.
> I put prints before and after call to napi_disable and see that it is called twice.
> I'll try to investigate in this direction.
>
> ib0: stopping interface
> ib0: before napi_disable
> ib0: after napi_disable
> ib0: downing ib_dev
> ib0: All sends and receives done.
> ib0: stopping interface
> ib0: before napi_disable
Yes, two napi_disable()s in a row without a matching napi_enable()
will deadlock. I guess the question is why the ipoib interface is
being stopped twice.
If you just take the net-2.6.24 tree (without bonding patches), does
bonding for ethernet interfaces work OK, or is there a similar problem
with double napi_disable()? How about bonding of ethernet after this
batch of bonding patches?
- R.
next prev parent reply other threads:[~2007-10-11 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11916151232222-git-send-email-fubar@us.ibm.com>
[not found] ` <470C200D.4010705@pobox.com>
2007-10-10 0:56 ` [PATCH] IB/ipoib: Bound the net device to the ipoib_neigh structue Jeff Garzik
2007-10-10 1:12 ` David Miller
2007-10-10 1:18 ` Jay Vosburgh
2007-10-10 16:03 ` Moni Shoua
2007-10-10 18:31 ` Roland Dreier
2007-10-11 14:48 ` Moni Shoua
2007-10-11 20:17 ` Roland Dreier [this message]
2007-10-11 22:01 ` Jay Vosburgh
2007-10-13 15:24 ` Moni Shoua
2007-10-14 15:51 ` Moni Shoua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada3awhcsnw.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=jeff@garzik.org \
--cc=monil@voltaire.com \
--cc=monis@voltaire.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).