From: Roland Dreier <rdreier@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: alexander.h.duyck@intel.com, shemminger@vyatta.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
gospo@redhat.com
Subject: Re: [net-next PATCH v3] igbvf: add new driver to support 82576 virtual functions
Date: Wed, 25 Mar 2009 20:21:08 -0700 [thread overview]
Message-ID: <ada4oxhufyz.fsf@cisco.com> (raw)
In-Reply-To: <20090325.201219.98810772.davem@davemloft.net> (David Miller's message of "Wed, 25 Mar 2009 20:12:19 -0700 (PDT)")
> > Since the issue isn't the igbvf driver there is no reason for it to
> > be held up.
>
> I disagree, I think both cases should be fixed.
>
> Just because we do something already never means that it's
> ok to proliferate the mistake further.
The igbvf driver doesn't proliferate any mistake. The num_vfs sysfs
attribute that everyone finds so objectionable is in the igb driver, and
if you follow the patchwork URL that was provided, you would see that
you applied the patch adding it back in February. The only thing the
igbvf driver does relating to this is bind to the PCI ID of the virtual
functions created by the igb driver.
- R.
next prev parent reply other threads:[~2009-03-26 3:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 21:52 [net-next PATCH v3] igbvf: add new driver to support 82576 virtual functions Jeff Kirsher
2009-03-25 22:00 ` Jeff Kirsher
2009-03-25 22:03 ` Stephen Hemminger
2009-03-25 22:33 ` Alexander Duyck
2009-03-25 23:58 ` David Miller
2009-03-26 0:54 ` Alexander Duyck
2009-03-26 2:33 ` Yu Zhao
2009-03-26 3:16 ` David Miller
2009-03-26 13:05 ` Patrick McHardy
2009-03-26 3:12 ` David Miller
2009-03-26 3:21 ` Roland Dreier [this message]
2009-03-26 3:33 ` David Miller
2009-03-26 3:27 ` Alexander Duyck
2009-03-26 3:34 ` David Miller
2009-03-27 0:30 ` [ RFC ] igb: first draft of igb rtnl_link_ops interface for vf creation (was Re: [net-next PATCH v3] igbvf: add new driver to support 82576 virtual functions) Alexander Duyck
2009-03-27 5:35 ` Patrick McHardy
2009-03-27 15:22 ` [ RFC ] igb: first draft of igb rtnl_link_ops interface for vf creation Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada4oxhufyz.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).