[patch 05/11] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create_eq()

[patch 05/11] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create_eq()

[akpm]

From: Roel Kluin <12o3l@tiscali.nl>


Cc: Joachim Fenkes <fenkes@de.ibm.com>
Cc: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
Cc: Heiko J Schick <schickhj.ibm.com>
Cc: Stefan Roscher <stefan.roscher@de.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/infiniband/hw/ehca/ehca_eq.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff -puN drivers/infiniband/hw/ehca/ehca_eq.c~ehca-ret-is-unsigned-ibmebus_request_irq-negative-return-ignored-in-hca_create_eq drivers/infiniband/hw/ehca/ehca_eq.c
--- a/drivers/infiniband/hw/ehca/ehca_eq.c~ehca-ret-is-unsigned-ibmebus_request_irq-negative-return-ignored-in-hca_create_eq
+++ a/drivers/infiniband/hw/ehca/ehca_eq.c
@@ -60,6 +60,7 @@ int ehca_create_eq(struct ehca_shca *shc
 	u32 i;
 	void *vpage;
 	struct ib_device *ib_dev = &shca->ib_device;
+	int ret2;
 
 	spin_lock_init(&eq->spinlock);
 	spin_lock_init(&eq->irq_spinlock);
@@ -122,18 +123,18 @@ int ehca_create_eq(struct ehca_shca *shc
 
 	/* register interrupt handlers and initialize work queues */
 	if (type == EHCA_EQ) {
-		ret = ibmebus_request_irq(eq->ist, ehca_interrupt_eq,
+		ret2 = ibmebus_request_irq(eq->ist, ehca_interrupt_eq,
 					  IRQF_DISABLED, "ehca_eq",
 					  (void *)shca);
-		if (ret < 0)
+		if (ret2 < 0)
 			ehca_err(ib_dev, "Can't map interrupt handler.");
 
 		tasklet_init(&eq->interrupt_task, ehca_tasklet_eq, (long)shca);
 	} else if (type == EHCA_NEQ) {
-		ret = ibmebus_request_irq(eq->ist, ehca_interrupt_neq,
+		ret2 = ibmebus_request_irq(eq->ist, ehca_interrupt_neq,
 					  IRQF_DISABLED, "ehca_neq",
 					  (void *)shca);
-		if (ret < 0)
+		if (ret2 < 0)
 			ehca_err(ib_dev, "Can't map interrupt handler.");
 
 		tasklet_init(&eq->interrupt_task, ehca_tasklet_neq, (long)shca);
_

Re: [patch 05/11] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create_eq()

[Roland Dreier]

This is a drivers/infiniband patch, not a drivers/net patch.

I believe this is already fixed upstream by 7df109d9 ("IB/ehca: handle
negative return value from ibmebus_request_irq() properly").

 - R.