From: Roland Dreier <rdreier@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: hch@lst.de, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] remove CONFIG_HAVE_ARCH_DEV_ALLOC_SKB
Date: Mon, 24 Jul 2006 15:44:15 -0700 [thread overview]
Message-ID: <ada4px6ipxc.fsf@cisco.com> (raw)
In-Reply-To: <20060724.153044.10246226.davem@davemloft.net> (David Miller's message of "Mon, 24 Jul 2006 15:30:44 -0700 (PDT)")
> skbuff.h has an #ifndef CONFIG_HAVE_ARCH_DEV_ALLOC_SKB to allow
> architectures to reimplement __dev_alloc_skb. It's not set on any
> architecture and now that we have an architecture-overrideable
> NET_SKB_PAD there is not point at all to have one either.
I missed this when hch first posted it, sorry.
But my impression was that the intent of the config option was to let
Xen hook __dev_alloc_skb() to allocate special receive skbs to handle
their page-flipping virtual network device. Which goes beyond
NET_SKB_PAD.
So the real question is about Xen hooks I guess -- and given where the
rest of Xen is, it probably does make sense to go ahead and strip this
out.
- R.
next prev parent reply other threads:[~2006-07-24 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 9:10 [PATCH 1/2] remove CONFIG_HAVE_ARCH_DEV_ALLOC_SKB Christoph Hellwig
2006-07-24 22:30 ` David Miller
2006-07-24 22:44 ` Roland Dreier [this message]
2006-07-26 7:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada4px6ipxc.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).