From: Roland Dreier <rdreier@cisco.com>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: netdev <netdev@vger.kernel.org>,
meder@de.ibm.com, raisch@de.ibm.com, schickhj@de.ibm.com,
themann@de.ibm.com
Subject: Re: [PATCH 2/6] ehea: pHYP interface
Date: Wed, 21 Jun 2006 08:36:05 -0700 [thread overview]
Message-ID: <ada4pyemsgq.fsf@cisco.com> (raw)
In-Reply-To: <44993E48.8060600@de.ibm.com> (Jan-Bernd Themann's message of "Wed, 21 Jun 2006 14:40:40 +0200")
I think this code needs to be refactored so that it can share with the
ehca InfiniBand driver (which should be merged upstream soon). For
example, you have ehea_hcall_7arg_7ret() and the ehca driver has an
identical ehca_hcall_7arg_7ret().
Also:
> +++ kernel/drivers/net/ehea/ehea_hcall.h 2006-06-21 04:44:50.158485520 -0700
> +/**
> + * This file contains HCALL defines that are to be included in the appropriate
> + * kernel files later
> + */
this stuff should go in <asm-powerpc/hvcall.h> with the other
constants, right?
next prev parent reply other threads:[~2006-06-21 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 12:40 [PATCH 2/6] ehea: pHYP interface Jan-Bernd Themann
2006-06-21 15:36 ` Roland Dreier [this message]
2006-06-26 16:17 ` Heiko J Schick
-- strict thread matches above, loose matches on Subject: below --
2006-08-09 8:38 Jan-Bernd Themann
2006-08-09 13:14 ` Arnd Bergmann
2006-08-10 15:12 ` Thomas Klein
2006-08-11 21:13 ` Anton Blanchard
2006-08-14 13:14 ` Jan-Bernd Themann
2006-08-11 21:19 ` Nathan Lynch
2006-08-11 21:26 ` Nathan Lynch
2006-08-21 12:04 ` Jan-Bernd Themann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada4pyemsgq.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=schickhj@de.ibm.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).