From: Roland Dreier <rdreier@cisco.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH] mv643xx_eth: fix SMI bus access timeouts
Date: Fri, 31 Oct 2008 22:47:47 -0700 [thread overview]
Message-ID: <ada63n8xaik.fsf@cisco.com> (raw)
In-Reply-To: <20081101053220.GA13348@xi.wantstofly.org> (Lennert Buytenhek's message of "Sat, 1 Nov 2008 06:32:20 +0100")
> If wait_event_timeout() would return zero, mv643xx_eth would conclude
> that the SMI access timed out, but this is not necessarily true --
> wait_event_timeout() can also return zero in the case where the SMI
> completion interrupt did happen in time but where it took longer than
> the requested timeout for the process performing the SMI access to be
> scheduled again. This would lead to occasional SMI access timeouts
> when the system would be under heavy load.
Would it make more sense to fix this in the wait_event_timeout() code
itself a la bb10ed09 ("sched: fix wait_for_completion_timeout() spurious
failure under heavy load")?
- R.
next prev parent reply other threads:[~2008-11-01 5:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 5:32 [PATCH] mv643xx_eth: fix SMI bus access timeouts Lennert Buytenhek
2008-11-01 5:47 ` Roland Dreier [this message]
2008-11-01 5:53 ` Lennert Buytenhek
2008-11-01 5:48 ` Lennert Buytenhek
2008-11-03 20:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada63n8xaik.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=buytenh@wantstofly.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).