[PATCH] pasemi_mac: Access iph->tot_len with correct endianness

[PATCH] pasemi_mac: Access iph->tot_len with correct endianness

[Roland Dreier]

iph->tot_len is stored in network byte order, so access it using
ntohs().  This doesn't have any real world impact on pasemi_mac, since
the device only exists as part of a big-endian system-on-chip, but
fixing this gets rid of a sparse warning and avoids having a bad example
in the tree.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
 drivers/net/pasemi_mac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c
index 3b2a6c5..993d87c 100644
--- a/drivers/net/pasemi_mac.c
+++ b/drivers/net/pasemi_mac.c
@@ -277,7 +277,7 @@ static int get_skb_hdr(struct sk_buff *skb, void **iphdr,
 	*tcph = tcp_hdr(skb);
 
 	/* check if ip header and tcp header are complete */
-	if (iph->tot_len < ip_len + tcp_hdrlen(skb))
+	if (ntohs(iph->tot_len) < ip_len + tcp_hdrlen(skb))
 		return -1;
 
 	*hdr_flags = LRO_IPV4 | LRO_TCP;

Re: [PATCH] pasemi_mac: Access iph->tot_len with correct endianness

[Olof Johansson]

On Tue, Jul 01, 2008 at 10:22:45AM -0700, Roland Dreier wrote:
> iph->tot_len is stored in network byte order, so access it using
> ntohs().  This doesn't have any real world impact on pasemi_mac, since
> the device only exists as part of a big-endian system-on-chip, but
> fixing this gets rid of a sparse warning and avoids having a bad example
> in the tree.
> 
> Signed-off-by: Roland Dreier <rolandd@cisco.com>

Acked-by: Olof Johansson <olof@lixom.net>