netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 14/14] nes: kernel build infrastructure
@ 2007-08-08  1:25 ggrundstrom
  2007-08-09 17:34 ` [ewg] " Roland Dreier
  0 siblings, 1 reply; 2+ messages in thread
From: ggrundstrom @ 2007-08-08  1:25 UTC (permalink / raw)
  To: rdreier; +Cc: ewg, ggrundstrom, netdev

Makefile kernel build file.

Signed-off-by: Glenn Grundstrom <ggrundstrom@neteffect.com>
---
diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/Makefile
--- NULL	1969-12-31 18:00:00.000000000 -0600
+++ ofa_kernel-1.2/drivers/infiniband/hw/nes/Makefile	2007-08-06 20:09:04.000000000 -0500
@@ -0,0 +1,10 @@
+ifdef CONFIG_INFINIBAND_NES_DEBUG
+EXTRA_CFLAGS += -DNES_DEBUG
+endif
+
+EXTRA_CFLAGS += -DNES_MINICM
+
+obj-$(CONFIG_INFINIBAND_NES) += iw_nes.o
+
+iw_nes-objs := nes.o nes_hw.o nes_nic.o nes_utils.o nes_verbs.o nes_cm.o
+

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ewg] [PATCH 14/14] nes: kernel build infrastructure
  2007-08-08  1:25 [PATCH 14/14] nes: kernel build infrastructure ggrundstrom
@ 2007-08-09 17:34 ` Roland Dreier
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2007-08-09 17:34 UTC (permalink / raw)
  To: ggrundstrom; +Cc: netdev, ewg

 > +ifdef CONFIG_INFINIBAND_NES_DEBUG
 > +EXTRA_CFLAGS += -DNES_DEBUG
 > +endif

I would just use the CONFIG_INFINIBAND_NES_DEBUG symbol directly in
your code.

 > +EXTRA_CFLAGS += -DNES_MINICM

If you're defining this unconditionally, can you just get rid of all
the tests of this symbol?

 - R.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-09 17:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-08  1:25 [PATCH 14/14] nes: kernel build infrastructure ggrundstrom
2007-08-09 17:34 ` [ewg] " Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).