From: Andrew Lunn <andrew@lunn.ch>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
FUJITA Tomonori <fujita.tomonori@gmail.com>,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
tmgross@umich.edu, benno.lossin@proton.me, wedsonaf@gmail.com
Subject: Re: [PATCH net-next v7 0/5] Rust abstractions for network PHY drivers
Date: Sat, 28 Oct 2023 17:00:55 +0200 [thread overview]
Message-ID: <ada8d010-52ac-46c1-b839-8d3b3ed59ae1@lunn.ch> (raw)
In-Reply-To: <CANiq72k4MFe2qL5XrweObo-bxT9qPA6+GAF4bSwLzyQJRX-mJw@mail.gmail.com>
On Sat, Oct 28, 2023 at 01:07:43PM +0200, Miguel Ojeda wrote:
> On Sat, Oct 28, 2023 at 12:55 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > You will probably find different levels of acceptance of 80 to 100 in
> > different subsystems. So i'm not sure you will be able to achieve
> > consistence.
>
> I would definitely agree if this were C. I happen to maintain
> `.clang-format`, and it was an interesting process to approximate a
> "common enough" style as the base one.
>
> But for Rust, it is easy, because all the code is new. All Rust files
> are formatted the same way, across the entire kernel.
I would say this is not a technical issue, but a social one. In order
to keep the netdev people happy, you are going to limit it to 80. But
i would not be too surprised if another subsystem says the code would
be more readable with 100, like the C code in our subsystem. We want
Rust to be 100 as well.
Linux can be very fragmented like this across subsystems. Its just the
way it is, and you might just have to fit in. I don't know, we will
see.
Andrew
next prev parent reply other threads:[~2023-10-28 15:00 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 0:10 [PATCH net-next v7 0/5] Rust abstractions for network PHY drivers FUJITA Tomonori
2023-10-26 0:10 ` [PATCH net-next v7 1/5] rust: core " FUJITA Tomonori
2023-10-27 19:09 ` Boqun Feng
2023-10-28 10:00 ` FUJITA Tomonori
2023-10-27 19:59 ` Boqun Feng
2023-10-27 21:19 ` Benno Lossin
2023-10-27 22:21 ` Boqun Feng
2023-10-27 22:36 ` Andrew Lunn
2023-10-27 22:50 ` Benno Lossin
2023-10-27 23:26 ` Boqun Feng
2023-10-27 23:52 ` Boqun Feng
2023-10-28 8:35 ` Benno Lossin
2023-10-27 22:40 ` Andrew Lunn
2023-10-28 15:16 ` Miguel Ojeda
2023-10-28 18:18 ` Andrew Lunn
2023-10-28 9:27 ` FUJITA Tomonori
2023-10-28 14:53 ` Andrew Lunn
2023-10-28 16:09 ` FUJITA Tomonori
2023-10-28 16:39 ` Benno Lossin
2023-10-28 19:06 ` Boqun Feng
2023-10-28 19:23 ` Andrew Lunn
2023-10-28 23:26 ` Boqun Feng
2023-10-28 16:37 ` Benno Lossin
2023-10-28 18:23 ` Andrew Lunn
2023-10-28 18:45 ` Benno Lossin
2023-10-29 4:21 ` FUJITA Tomonori
2023-10-29 16:48 ` Boqun Feng
2023-10-29 18:09 ` Boqun Feng
2023-10-29 18:26 ` Boqun Feng
2023-10-29 19:39 ` Andrew Lunn
2023-10-30 12:07 ` Miguel Ojeda
2023-10-30 12:32 ` Andrew Lunn
2023-10-29 22:58 ` FUJITA Tomonori
2023-10-30 0:19 ` Boqun Feng
2023-10-30 8:34 ` Benno Lossin
2023-10-30 12:49 ` FUJITA Tomonori
2023-10-30 16:45 ` Benno Lossin
2023-11-08 10:46 ` FUJITA Tomonori
2023-11-10 13:26 ` Andrew Lunn
2023-10-29 17:32 ` Andrew Lunn
2023-10-30 8:37 ` Benno Lossin
2023-10-30 11:22 ` Miguel Ojeda
2023-11-17 9:39 ` Alice Ryhl
2023-11-17 13:34 ` Andrew Lunn
2023-11-17 15:42 ` Alice Ryhl
2023-11-17 16:28 ` Andrew Lunn
2023-11-17 18:27 ` Alice Ryhl
2023-11-21 12:47 ` FUJITA Tomonori
2023-11-17 9:39 ` Alice Ryhl
2023-11-17 13:53 ` Andrew Lunn
2023-11-17 19:50 ` Greg KH
2023-11-17 23:28 ` Boqun Feng
2023-11-18 15:32 ` Andrew Lunn
2023-11-18 15:54 ` Boqun Feng
2023-11-19 11:06 ` Trevor Gross
2023-11-21 2:13 ` FUJITA Tomonori
2023-11-22 18:16 ` Boqun Feng
2023-11-19 13:51 ` FUJITA Tomonori
2023-11-19 16:08 ` Andrew Lunn
2023-10-26 0:10 ` [PATCH net-next v7 2/5] rust: net::phy add module_phy_driver macro FUJITA Tomonori
2023-11-17 9:39 ` Alice Ryhl
2023-11-19 10:50 ` FUJITA Tomonori
2023-11-19 10:54 ` Benno Lossin
2023-11-17 22:21 ` Boqun Feng
2023-11-17 22:54 ` Andrew Lunn
2023-11-17 23:01 ` Benno Lossin
2023-11-17 23:18 ` Andrew Lunn
2023-11-19 9:41 ` FUJITA Tomonori
2023-11-19 9:25 ` FUJITA Tomonori
2023-11-19 15:50 ` Andrew Lunn
2023-11-20 13:54 ` FUJITA Tomonori
2023-11-20 14:13 ` Andrew Lunn
2023-11-21 0:49 ` FUJITA Tomonori
2023-11-19 9:44 ` FUJITA Tomonori
2023-10-26 0:10 ` [PATCH net-next v7 3/5] rust: add second `bindgen` pass for enum exhaustiveness checking FUJITA Tomonori
2023-10-26 11:02 ` Miguel Ojeda
2023-10-26 11:54 ` FUJITA Tomonori
2023-10-26 12:22 ` Miguel Ojeda
2023-10-27 0:07 ` Andrew Lunn
2023-10-27 10:50 ` Miguel Ojeda
2023-10-26 0:10 ` [PATCH net-next v7 4/5] MAINTAINERS: add Rust PHY abstractions for ETHERNET PHY LIBRARY FUJITA Tomonori
2023-10-26 23:53 ` Andrew Lunn
2023-10-26 0:10 ` [PATCH net-next v7 5/5] net: phy: add Rust Asix PHY driver FUJITA Tomonori
2023-11-17 9:39 ` Alice Ryhl
2023-11-19 9:57 ` FUJITA Tomonori
2023-11-19 16:03 ` Andrew Lunn
2023-11-21 6:19 ` FUJITA Tomonori
2023-11-21 7:12 ` Greg KH
2023-10-26 10:39 ` [PATCH net-next v7 0/5] Rust abstractions for network PHY drivers Miguel Ojeda
2023-10-26 23:48 ` Andrew Lunn
2023-10-27 2:06 ` Boqun Feng
2023-10-27 2:47 ` Andrew Lunn
2023-10-27 3:11 ` Boqun Feng
2023-10-27 4:26 ` Boqun Feng
2023-10-27 14:26 ` Andrew Lunn
2023-10-27 16:41 ` Miguel Ojeda
2023-10-27 13:00 ` Andrew Lunn
2023-10-27 10:22 ` Miguel Ojeda
2023-10-27 13:09 ` Andrew Lunn
2023-10-27 10:21 ` Miguel Ojeda
2023-10-27 14:26 ` Jakub Kicinski
2023-10-27 16:36 ` Miguel Ojeda
2023-10-27 22:55 ` Andrew Lunn
2023-10-28 11:07 ` Miguel Ojeda
2023-10-28 11:41 ` Benno Lossin
2023-10-28 15:11 ` Miguel Ojeda
2023-10-28 15:00 ` Andrew Lunn [this message]
2023-10-28 15:11 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada8d010-52ac-46c1-b839-8d3b3ed59ae1@lunn.ch \
--to=andrew@lunn.ch \
--cc=benno.lossin@proton.me \
--cc=fujita.tomonori@gmail.com \
--cc=kuba@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).