From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D5C717335B for ; Thu, 18 Apr 2024 20:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713471639; cv=none; b=efvj3n29Bn5Pc0ra7S8xjI0ACEuTuD82LWsFQeA5+vLFTP6TU9O4+lilxQpnVYo+FQclU2Ef+cHFzz5etY+5LhE0P2SZQE7L5e531ax+TtC7IiEI+IZ9JOMf0mlyyDW+/WsBZbzrwNXl0TmgxaeWyNpZq1T/ubpXIU4nENMMAEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713471639; c=relaxed/simple; bh=1QbGatMHVWUgzHqicfmSCgb3DA46haEIhxlTc9G6cnw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L2WpdDldF40oi2YvuS449BVhi4ssvMAlQOXEM4qNVAHZWZZSyQchLf/0+zZ+2TenORtVdgo09gSxfUcPHQWr/FAesTaGHp4H88vKjn63c9cr3KQu5d9zC4Y2EiX0u2uFvw55c2ePIC8/QmdNtYNDWG7mw+U6hjEFs6Xe7r6IFzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S+gMIrZ5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S+gMIrZ5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1E91C113CC; Thu, 18 Apr 2024 20:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713471639; bh=1QbGatMHVWUgzHqicfmSCgb3DA46haEIhxlTc9G6cnw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S+gMIrZ5nyM7sOzL3U6ja6HT7ugU3Tt25JLLPOt5dgSlH2aZS8xknHTSq7DrFJtds nuz/6Hk2yB7UJshor6lt1OKu/LPfMlOJf/CtR/1n3a+2sEbj6wBINM1WoVHv/p7o0C tlj7qdh/kFaD7kprSL1QudG7qmEc9dr6XEeApFnqbwaU80kFcO4cKajjTN+SIK/RM3 rJEMmxWwQ+gYSG+X+RAq1w6KRvx1lvn9+N8zA+no5Lug8EU1G81wmBiZv+Wwwzj6fn BlW6DVBgUMfcFtcw1VqcYxM808nyP52m292SRsXzM3FAriYrvjfeIzYsZAmh6yoAV9 XqYekm7jNZz6g== Message-ID: Date: Thu, 18 Apr 2024 13:20:37 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] tcp: conditionally call ip_icmp_error() from tcp_v4_err() Content-Language: en-US To: Jakub Kicinski , Eric Dumazet Cc: Paolo Abeni , "David S . Miller" , netdev@vger.kernel.org, Neal Cardwell , Dragos Tatulea , eric.dumazet@gmail.com, =?UTF-8?Q?Maciej_=C5=BBenczykowski?= , Willem de Bruijn , Shachar Kagan References: <20240417165756.2531620-1-edumazet@google.com> <20240417165756.2531620-2-edumazet@google.com> <7d1aa7d5a134ad4f4bca215ec6a075190cea03f2.camel@redhat.com> <274d458e-36c8-4742-9923-6944d3ef44b5@kernel.org> <20240418110909.091b0550@kernel.org> From: David Ahern In-Reply-To: <20240418110909.091b0550@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/18/24 12:09 PM, Jakub Kicinski wrote: > On Thu, 18 Apr 2024 19:47:51 +0200 Eric Dumazet wrote: >>> You have a kernel patch that makes a test fail, and your solution is >>> changing userspace? The tests are examples of userspace applications and >>> how they can use APIs, so if the patch breaks a test it is by definition >>> breaking userspace which is not allowed. > > Tests are often overly sensitive to kernel behavior, while this is That test script is a fairly comprehensive sweep of uAPIs and kernel behavior. Its sole job is to detect user visible changes and breakage from patches. It has done its job here. Do not shoot or criticize the messenger because you do not like the message. > obviously a red flag it's not an automatic nack. The more tests we > have the more often we'll catch tiny changes. A lot of tests started > flaking with 6.9 because of the optimizations in the timer subsystem. > You know where I'm going with this.. > >> I think the userspace program relied on a bug added in linux in 2020 >> >> Jakub, I will stop trying to push the patches, this is a lost battle. > > If you have the patches ready - please post them. > I'm happy to take the blame if they actually regress something in > the wild :( And because of this test suite you are making a conscious decision to merge a patch that is making a user visible change. That is part of the tough decisions a maintainer has to make; I have no problem with that.