From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84AAA347FE1 for ; Wed, 8 Apr 2026 16:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775666556; cv=none; b=IcxlaYJjnFCXB2DlJ9opLn7ToKsfg2LjTfYB63dXNTIS1md0MyJGKFxRJ8+S9Jw6pQy9j9kkuBc2NG2YHllYXYjVZwJaai1xQP+AT/Ng5S7VgrLS2FG6FdoZnG9KZsDwEixG+dZ7G7TA47BKNGJ9dg+joJMG89subzcYsntXGzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775666556; c=relaxed/simple; bh=bLTx+c32C/qCHUhoY7N2Byd8IuNJWjj4peOddNFV/tg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e2jV80X1e3rlnsxMX9AY8uJ/3jmfspCLpZjdyrYoXcUdgRQF2zXOiGgBmMMQfJbOYZsLoi0sCD4+QPJH5YxEPcUkL069XoOKO9hPJVNZ/MtVFPkXQN2dqu6pbf5QiZc0TUR4QhqMBp8mez5YUkFCQmT8MSTpPwz5dJgkLALWOT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ufh9vfJv; arc=none smtp.client-ip=209.85.210.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ufh9vfJv" Received: by mail-ot1-f65.google.com with SMTP id 46e09a7af769-7dbd2a0211bso22579a34.0 for ; Wed, 08 Apr 2026 09:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775666554; x=1776271354; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=AZ2Mix/WsrjuvVUa/+AnBSq7oOCxR/J1k92RQPsE65E=; b=Ufh9vfJvLsHaNBzA05Q8+VpuyYa8nVYc1tiO9AfLms29/IZ6Zj6OKGFL4uOpYHd3P9 beEk8q1R6XtFdwpSJGLoKqGXtlqvaThxgjQsqB/SKc8ZHT5iRq2nYUzLGQKH952zhpSJ YwmalQ7nXtgllfREtsmo41Blb9q7LCjUi0pqfiqQD9X4+5BglmMupL6qTYhAYMbvuF81 ByqLZTQuuIxfHG6R2ZwJTCvvDFAf3csjs1UZNusadui3zynluRjWvCCSLk8D5VdpyN8q WzfSbQbVP0ocayCMpGs2v9lhEVJBEUiAqfbsx9NKm7s8pj3rjVCuzc7ZxkscU1xiaCUi cREw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775666554; x=1776271354; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AZ2Mix/WsrjuvVUa/+AnBSq7oOCxR/J1k92RQPsE65E=; b=HgZlh1AObT7DHj5YepZxIXODADk7Vne3hpywmsNVC+UGcksRpeUTCFG5XqPQBqgdcd KLj0mqsyL/QNO7Q2RL7JNF3A9gPdyjPPRw7BIZL5LJusz1HFEL+3SneDi0WvE0P6ihgI 6+bJbZh3A1hY3LJZ8DCfsl0yWxC5kb1mo7qUCPrVqQY0ykJrC1Rnr5/WZeH5R+QCBlAF 11xf1Jnf1CsO11FRzSm0kB6tiA7+eNIx6M/CmHWvB2kro0KWrbig5cCm35sVk6sfMGyJ JQhEueKuXTpbAzMJ/OCbZDb6AvUlMfENgIb4kJicb6Nx+WUdqaRcaYU6NlKK0lX3Nr7p MFfg== X-Forwarded-Encrypted: i=1; AJvYcCWKpcQGEIkvhtD4VSGGPKqQyesLGdo5GhdmQDExcHem3XSxGeVsYxT+CJpGuvxSBOjf5/VP1oY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj/2pvh54Q/1h7ZXfSKtKvZLSonWRpWt4AqS5X/FFOv6oKhUqj +2ZO+lyIJkrW1+ybxu+AYsBQKuA7uqoMod3XPjBhHJ/QxmFd4g3NhYcL X-Gm-Gg: AeBDietFSt9NuCeM45I00D++fz32rwoX6qzk8ZIG4STTn2tEhJLGXeXQZ0kSWurRz6Z TxLvnke82ttkF60wlPfNP131v8mrkOxvXWV7Dw+S2a/ddBLCCIC4X7gG+w21isV8mcKpID/cmuD PlBStdl/76nJWx2SkrEntDarubRIDSTdzDtH8ODy6XhgoKprajsnuZoW/iUCchCm4VTC6Q+e3qH cQhQa90hXCgNCCc8BzIxJ62nGzwq35zKLW+CqTNyPdk51/JQg1ZzC3XgpweYvUOhZd3Zn7Pn0eL cpM/3oK1sPoHlLYbKMdsKfeqhefj3Ltg0hPuN1BdiO46q3AtvPtxJUMwHTH8thtOwyZ9ZaczTgx 0x5/UKDexBWA7Bi6EPAV8Ftx9OaaYfZa+69cY4UOeLvB97u8+yC+d0YKZiQw9xBFQTqXuyufyPa RajX6zYCDZ5cE/vGnUXA== X-Received: by 2002:a05:6820:1510:b0:67e:2fcc:fa99 with SMTP id 006d021491bc7-68220e45ed8mr11105185eaf.55.1775666554413; Wed, 08 Apr 2026 09:42:34 -0700 (PDT) Received: from localhost ([2a03:2880:12ff:72::]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-68897af6975sm2288130eaf.6.2026.04.08.09.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 09:42:34 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev Date: Wed, 8 Apr 2026 09:42:33 -0700 To: Hangbin Liu Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 1/5] tools: ynl: move ethtool.py to selftest Message-ID: References: <20260408-b4-ynl_ethtool-v2-0-7623a5e8f70b@gmail.com> <20260408-b4-ynl_ethtool-v2-1-7623a5e8f70b@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408-b4-ynl_ethtool-v2-1-7623a5e8f70b@gmail.com> On 04/08, Hangbin Liu wrote: > We have converted all the samples to selftests. This script is > the last piece of random "PoC" code we still have lying around. > Let's move it to tests. > > Signed-off-by: Hangbin Liu > --- > tools/net/ynl/tests/Makefile | 5 ++++- > tools/net/ynl/{pyynl => tests}/ethtool.py | 2 +- > tools/net/ynl/tests/test_ynl_ethtool.sh | 2 +- > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/net/ynl/tests/Makefile b/tools/net/ynl/tests/Makefile > index 2a02958c7039..94bf0346b54d 100644 > --- a/tools/net/ynl/tests/Makefile > +++ b/tools/net/ynl/tests/Makefile > @@ -36,7 +36,10 @@ TEST_GEN_FILES := \ > rt-route \ > # end of TEST_GEN_FILES > > -TEST_FILES := ynl_nsim_lib.sh > +TEST_FILES := \ > + ethtool.py \ > + ynl_nsim_lib.sh \ > +# end of TEST_FILES > > CFLAGS_netdev:=$(CFLAGS_netdev) $(CFLAGS_rt-link) > CFLAGS_ovs:=$(CFLAGS_ovs_datapath) > diff --git a/tools/net/ynl/pyynl/ethtool.py b/tools/net/ynl/tests/ethtool.py > similarity index 99% > rename from tools/net/ynl/pyynl/ethtool.py > rename to tools/net/ynl/tests/ethtool.py > index f1a2a2a89985..6eeeb867edcf 100755 > --- a/tools/net/ynl/pyynl/ethtool.py > +++ b/tools/net/ynl/tests/ethtool.py > @@ -14,7 +14,7 @@ import re > import os > > # pylint: disable=no-name-in-module,wrong-import-position > -sys.path.append(pathlib.Path(__file__).resolve().parent.as_posix()) > +sys.path.append(pathlib.Path(__file__).resolve().parent.parent.joinpath('pyynl').as_posix()) > # pylint: disable=import-error > from cli import schema_dir, spec_dir > from lib import YnlFamily > diff --git a/tools/net/ynl/tests/test_ynl_ethtool.sh b/tools/net/ynl/tests/test_ynl_ethtool.sh > index b826269017f4..b4480e9be7b7 100755 > --- a/tools/net/ynl/tests/test_ynl_ethtool.sh > +++ b/tools/net/ynl/tests/test_ynl_ethtool.sh > @@ -8,7 +8,7 @@ KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests > source "$KSELFTEST_KTAP_HELPERS" > > # Default ynl-ethtool path for direct execution, can be overridden by make install > -ynl_ethtool="../pyynl/ethtool.py" > +ynl_ethtool="./ethtool.py" > > readonly NSIM_ID="1337" > readonly NSIM_DEV_NAME="nsim${NSIM_ID}" Do we need to add some expects/asserts to the script to really make it into a test? Right now it just prints things, so it's not really a test.