From: Roland Dreier <rdreier@cisco.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
Alexander Duyck <alexander.h.duyck@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver
Date: Fri, 21 Nov 2008 09:58:37 -0800 [thread overview]
Message-ID: <adaabbtgdv6.fsf@cisco.com> (raw)
In-Reply-To: <4926B26C.7010200@trash.net> (Patrick McHardy's message of "Fri, 21 Nov 2008 14:06:52 +0100")
> > --- /dev/null
> > +++ b/net/dcb/Kconfig
> > @@ -0,0 +1,12 @@
> > +config DCB
> > + tristate "Data Center Bridging support"
> A help text would be nice to have.
Yes, agreed -- something giving a hint about what DCB is (per-priority
pause, BCN) and guidance for the user that this should be enabled if
using DCB-capable NICs and switches.
> > +
> > +config DCBNL
> > + bool "Data Center Bridging netlink interface support"
> > + depends on DCB
> > + default n
> > + ---help---
> > + This option turns on the netlink interface
> > + (dcbnl) for Data Center Bridging capable devices.
> > +
> > + If unsure, say N.
Now that I look at this config, it looks rather strange. When does is
ever make sense to enable DCB but not DCBNL? How else does one
configure all the DCB parameters except by running dcbd in userspace?
Should there even be a separate DCBNL option at all?
- R.
next prev parent reply other threads:[~2008-11-21 17:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 2:00 [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver Jeff Kirsher
2008-11-21 2:01 ` [NET-NEXT v4 PATCH 2/5] DCB: Add interface to query for the DCB capabilities of an device Jeff Kirsher
2008-11-21 5:07 ` David Miller
2008-11-21 2:01 ` [NET-NEXT v4 PATCH 3/5] DCB: Add interface to query # of TCs supported by device Jeff Kirsher
2008-11-21 5:08 ` David Miller
2008-11-21 2:01 ` [NET-NEXT v4 PATCH 4/5] DCB: Add interface to query the state of PFC feature Jeff Kirsher
2008-11-21 5:09 ` David Miller
2008-11-21 2:02 ` [NET-NEXT v4 PATCH 5/5] DCB: Add support for DCB BCN Jeff Kirsher
2008-11-21 5:10 ` David Miller
2008-11-21 5:02 ` [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver David Miller
2008-11-21 9:14 ` Wang Chen
2008-11-21 9:21 ` David Miller
2008-11-21 9:32 ` [NET-NEXT PATCH] ixgbe: convert directly reference of netdev->priv Wang Chen
2008-11-21 9:57 ` David Miller
2008-11-21 13:06 ` [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver Patrick McHardy
2008-11-21 17:58 ` Roland Dreier [this message]
2008-11-21 22:20 ` Jeff Kirsher
2008-11-22 0:48 ` David Miller
2008-11-22 0:57 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaabbtgdv6.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).