From: Roland Dreier <rdreier@cisco.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org, ewg@lists.openfabrics.org,
general@lists.openfabrics.org
Subject: [ofa-general] Re: [PATCH 2/14 v2] nes: device structures and defines
Date: Fri, 19 Oct 2007 22:22:44 -0700 [thread overview]
Message-ID: <adaabqebbrv.fsf@cisco.com> (raw)
In-Reply-To: <20071019220015.3faa9bbb@freepuppy.rosehill> (Stephen Hemminger's message of "Fri, 19 Oct 2007 22:00:15 -0700")
> You are starting off on the wrong foot.
???
> > +if(!(expr)) { \
> > + printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n", \
> > + #expr, __FILE__, __FUNCTION__, __LINE__); \
> > +}
>
> Use BUG_ON
I agree that there's no need to invent a driver-private assertion
macro, but (to first order at least) drivers should never use BUG_ON.
I don't want some glitch in a network driver that the system could
probably survive to be turned into a panic by BUG_ON -- WARN_ON seems
infinitely preferable.
- R.
next prev parent reply other threads:[~2007-10-20 5:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 20:04 [ofa-general] [PATCH 2/14 v2] nes: device structures and defines ggrundstrom
2007-10-20 5:00 ` [ofa-general] " Stephen Hemminger
2007-10-20 5:22 ` Roland Dreier [this message]
2007-10-20 5:26 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaabqebbrv.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=ewg@lists.openfabrics.org \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).