From: Roland Dreier <rdreier@cisco.com>
To: Karen Xie <kxie@chelsio.com>
Cc: netdev@vger.kernel.org, open-iscsi@googlegroups.com,
jgarzik@pobox.com, davem@davemloft.net, michaelc@cs.wisc.edu,
swise@opengridcomputing.com, daisyc@us.ibm.com,
wenxiong@us.ibm.com, bhua@us.ibm.com, divy@chelsio.com,
dm@chelsio.com, leedom@chelsio.com
Subject: Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Date: Wed, 30 Jul 2008 12:21:24 -0700 [thread overview]
Message-ID: <adabq0fyy8b.fsf@cisco.com> (raw)
In-Reply-To: <200807300019.m6U0JkdY012558@localhost.localdomain> (Karen Xie's message of "Tue, 29 Jul 2008 17:19:46 -0700")
> Cxgb3i iSCSI driver
I think a little more detail in the changelog would be
helpful... something like what you had in the 0/1 email (no reason to
put that nice info in an email that will be discarded rather than in the
patch that will be merged). Maybe:
The cxgb3i driver provides iscsi acceleration (PDU digest offload and
payload direct-placement) to the open-iscsi initiator. It accesses
the hardware through the cxgb3 module.
I didn't read in detail yet but one quick comments:
> --- /dev/null
> +++ b/drivers/scsi/cxgb3i/Kconfig
> @@ -0,0 +1,6 @@
> +config SCSI_CXGB3_ISCSI
> + tristate "Chelsio S3xx iSCSI support"
> + select CHELSIO_T3
> + select SCSI_ISCSI_ATTRS
> + ---help---
> + This driver supports iSCSI offload for the Chelsio S3 series devices.
I don't see any other Kconfig changes that hook this Kconfig file into
the build? Also are there sufficient dependencies to avoid broken
configs here?
next prev parent reply other threads:[~2008-07-30 19:21 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 0:19 [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator Karen Xie
2008-07-30 18:15 ` Shyam_Iyer
2008-07-30 18:37 ` Karen Xie
2008-07-30 19:21 ` Roland Dreier [this message]
2008-07-30 19:35 ` Jeff Garzik
2008-07-30 21:35 ` Roland Dreier
2008-08-01 0:51 ` Divy Le Ray
2008-08-07 18:45 ` Divy Le Ray
2008-08-07 20:07 ` Mike Christie
2008-08-08 18:09 ` Steve Wise
2008-08-08 22:15 ` Jeff Garzik
2008-08-08 22:20 ` Jeff Garzik
2008-08-09 7:28 ` David Miller
2008-08-09 14:04 ` Steve Wise
2008-08-10 5:14 ` Roland Dreier
2008-08-10 5:47 ` David Miller
2008-08-10 6:34 ` Herbert Xu
2008-08-10 17:57 ` Steve Wise
2008-08-11 16:09 ` Roland Dreier
2008-08-11 21:09 ` David Miller
2008-08-11 21:37 ` Roland Dreier
2008-08-11 21:51 ` David Miller
2008-08-11 23:20 ` Steve Wise
2008-08-11 23:45 ` Divy Le Ray
2008-08-12 0:22 ` David Miller
2008-08-10 5:12 ` Roland Dreier
2008-08-10 5:46 ` David Miller
2008-08-11 16:07 ` Roland Dreier
2008-08-11 21:08 ` David Miller
2008-08-11 21:39 ` Roland Dreier
2008-08-11 21:52 ` David Miller
2008-08-11 18:13 ` Rick Jones
2008-08-11 21:12 ` David Miller
2008-08-11 21:41 ` Roland Dreier
2008-08-11 21:53 ` David Miller
2008-08-12 21:57 ` Divy Le Ray
2008-08-12 22:01 ` David Miller
2008-08-12 22:02 ` David Miller
2008-08-12 22:21 ` Divy Le Ray
2008-08-13 1:57 ` Herbert Xu
2008-08-13 18:35 ` Vladislav Bolkhovitin
2008-08-13 19:29 ` Jeff Garzik
2008-08-13 20:13 ` David Miller
2008-08-14 18:24 ` Vladislav Bolkhovitin
2008-08-14 21:59 ` Nicholas A. Bellinger
2008-08-13 20:23 ` David Miller
2008-08-14 18:27 ` Vladislav Bolkhovitin
2008-08-14 18:30 ` Vladislav Bolkhovitin
2008-08-13 21:27 ` Roland Dreier
2008-08-13 22:08 ` David Miller
2008-08-13 23:03 ` Roland Dreier
2008-08-13 23:12 ` David Miller
2008-08-14 1:26 ` Tom Tucker
2008-08-14 1:37 ` David Miller
2008-08-14 1:52 ` Steve Wise
2008-08-14 2:05 ` David Miller
2008-08-14 2:44 ` Steve Wise
2008-08-14 1:57 ` Tom Tucker
2008-08-14 2:07 ` David Miller
2008-08-14 2:09 ` David Miller
2008-08-14 20:45 ` Andrew Gallatin
2008-08-14 22:23 ` David Miller
2008-08-15 12:19 ` Andrew Gallatin
2008-08-10 6:24 ` Herbert Xu
2008-08-10 9:19 ` Alan Cox
2008-08-10 12:49 ` Jeff Garzik
2008-08-10 14:54 ` James Bottomley
[not found] ` <1218380086.3418.21.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-11 16:50 ` Mike Christie
2008-07-31 1:24 ` Karen Xie
2008-07-31 12:45 ` Boaz Harrosh
2008-07-31 12:33 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adabq0fyy8b.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=bhua@us.ibm.com \
--cc=daisyc@us.ibm.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=dm@chelsio.com \
--cc=jgarzik@pobox.com \
--cc=kxie@chelsio.com \
--cc=leedom@chelsio.com \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=swise@opengridcomputing.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).