netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Salyzyn <salyzyn@android.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: refcount_t + (resend to wider audience)
Date: Fri, 28 Jul 2017 10:15:23 -0700	[thread overview]
Message-ID: <adaee9d9-1d35-921c-36b3-e32e6c8ce9e3@android.com> (raw)
In-Reply-To: <cc109bec-d4bb-8965-3169-fe36d85e6e19@android.com>

(Resend to wider audience to comply with 
Documentation/networking/netdev-FAQ.txt)

Please apply/backport the following upstream feature and followup
grouped fixes patches to the stable trees (expect included in at least
3.10.y, 3.18.y, 4.4.y and 4.9.y):


GROUP 1: refcount_t feature:

f405df5de3170c00e5c54f8b7cf4766044a032ba refcount_t: Introduce a special
purpose refcount type
29dee3c03abce04cd527878ef5f9e5f91b7b83f4 locking/refcounts: Out-of-line
everything
bd174169c7a12a37b3b4aa2221f084ade010b182 locking/refcount: Add
refcount_t API kernel-doc comments
fd25d19f6b8da315332bb75936605fb45d3ea981 locking/refcount: Create
unchecked atomic_t implementation

They should merge cleanly as they are orthogonal, except for the last
one which will have a trivial merge conflict to arch/Kconfig.

Following these that add the refcount_t upstream API, the following
groups of
upsteam patches are requested because we are experiencing KASAN errors:


GROUP 2: sk_buff.users:

3889a803e1da9bd7cd10d6504bf281ee7e55dfd6 net: factor out a helper to
decrement the skb refcount
7608894e43d071ef2322a01c79522954c070ac6c net: use skb_unref() in
napi_consume_skb()
9899886d5e8ec5b343b1efe44f185a0e68dc6454 net: core: Prevent from
dereferencing null pointer when releasing SKB
633547973ffc32fd2c815639d4675e1531f0896f net: convert sk_buff.users from
atomic_t to refcount_t

They appear to merge trivially (4.9), but the last one will likely need
#include
<linux/refcount.h> added after the #include <lunux/atomic.h> in
include/linux/skbuff.h to facilitate compilation.


GROUP 3: sec_path.refcnt:

b0fcee825c0ad05057a97d1f4685e1b9e9d00c53 xfrm: Add a secpath_set helper.
55eabed60a68e918abc44f6beb64f38cc008b29d net, xfrm: convert
sec_path.refcnt from atomic_t to refcount_t

They merged with zero conflict on 4.9.


GROUP 4: sock.sk_wmem_alloc

14afee4b6092fde451ee17604e5f5c89da33e71e net: convert sock.sk_wmem_alloc
from atomic_t to refcount_t

This did not merge entirely cleanly (4.9), appears fragments for
net/ipv4/esp4.c and net/ipv6/esp6.c need to be dropped as well as minor
conflicts in two other files.


There may be more related to follow as our investigations continue, but
this is already turning into a tall order so we stop here.


Sincerely -- Mark Salyzyn

       reply	other threads:[~2017-07-28 17:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cc109bec-d4bb-8965-3169-fe36d85e6e19@android.com>
2017-07-28 17:15 ` Mark Salyzyn [this message]
2017-07-28 17:41   ` refcount_t + (resend to wider audience) Andrew Lunn
2017-07-28 18:07     ` Mark Salyzyn
2017-07-28 19:31       ` David Miller
2017-07-28 19:59         ` Mark Salyzyn
2017-07-28 21:23           ` Andrew Lunn
2017-07-28 19:29   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaee9d9-1d35-921c-36b3-e32e6c8ce9e3@android.com \
    --to=salyzyn@android.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).