From: Roland Dreier <rdreier@cisco.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "Divy Le Ray <divy@chelsio.com>" <divy@chelsio.com>,
jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/10] cxgb3 - main header files
Date: Fri, 17 Nov 2006 13:48:14 -0800 [thread overview]
Message-ID: <adaejs1lp7l.fsf@cisco.com> (raw)
In-Reply-To: <20061117124902.7e69af2e@freekitty> (Stephen Hemminger's message of "Fri, 17 Nov 2006 12:49:02 -0800")
> > +#define MDIO_LOCK(adapter) down(&(adapter)->mdio_lock)
> > +#define MDIO_UNLOCK(adapter) up(&(adapter)->mdio_lock)
>
> Please don't wrap locks
Plus these should probably be mutexes, not semaphores.
> > +int t3_offload_tx(struct t3cdev *tdev, struct sk_buff *skb);
>
> What kind of offload? You remember TOE was rejected.
But we're OK with RDMA over TCP (iWARP) I think...
- R.
next prev parent reply other threads:[~2006-11-17 21:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 20:23 [PATCH 1/10] cxgb3 - main header files Divy Le Ray <divy@chelsio.com>
2006-11-17 20:49 ` Stephen Hemminger
2006-11-17 21:48 ` Roland Dreier [this message]
2006-11-18 17:25 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2006-12-04 19:44 Divy Le Ray
2006-12-08 3:26 Divy Le Ray
2006-12-14 5:41 Divy Le Ray
2006-12-20 12:41 Divy Le Ray
2006-12-26 20:57 ` Jeff Garzik
2006-12-27 8:52 ` Divy Le Ray
2006-12-27 9:03 ` Arjan van de Ven
2007-01-09 10:19 ` Divy Le Ray
2007-01-09 10:28 ` Jeff Garzik
2007-01-09 13:38 ` Steve Wise
2007-01-09 13:57 ` Michael S. Tsirkin
2007-01-09 14:46 ` Steve Wise
2007-01-09 18:29 ` Caitlin Bestler
2007-01-09 16:28 ` Roland Dreier
2007-01-09 16:41 ` Jeff Garzik
2007-01-09 17:09 ` Roland Dreier
2007-01-19 3:05 ` Jeff Garzik
2006-12-22 7:20 Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaejs1lp7l.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).