From: Roland Dreier <rdreier@cisco.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Stephen Hemminger <shemminger@osdl.org>,
davem@davemloft.net, chas@cmf.nrl.navy.mil,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] atm: clip timer race
Date: Thu, 13 Apr 2006 14:08:29 -0700 [thread overview]
Message-ID: <adaek01p4j6.fsf@cisco.com> (raw)
In-Reply-To: <20060413124534.GA25333@gondor.apana.org.au> (Herbert Xu's message of "Thu, 13 Apr 2006 22:45:34 +1000")
Herbert> I don't think this is enough though since this timer is
Herbert> one of those self-rescheduling timers. You need to
Herbert> provide some sort of a flag for it to stop scheduling
Herbert> itself and synchronise it properly.
I'm probably missing an obvious race but it seems del_timer_sync()
should be fine on a timer that reschedules itself. del_timer_sync()
loops until try_to_del_timer_sync() succeeds, and
try_to_del_timer_sync() will fail unless the timer being killed is not
running (and it does this test with the timer base lock held).
OK, how am I being stupid?
- R.
next prev parent reply other threads:[~2006-04-13 21:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 17:55 [PATCH] atm: clip causes unregister hang Stephen Hemminger
2006-04-12 18:08 ` Herbert Xu
2006-04-12 19:45 ` Stephen Hemminger
2006-04-12 20:00 ` Herbert Xu
2006-04-12 20:15 ` Stephen Hemminger
2006-04-12 20:25 ` Herbert Xu
2006-04-12 21:52 ` Stephen Hemminger
2006-04-12 22:42 ` [PATCH] atm: clip timer race Stephen Hemminger
2006-04-13 12:45 ` Herbert Xu
2006-04-13 17:26 ` Stephen Hemminger
2006-04-13 17:31 ` Herbert Xu
2006-04-13 21:08 ` Roland Dreier [this message]
2006-04-13 22:11 ` Herbert Xu
2006-04-14 22:56 ` David S. Miller
2006-04-13 12:28 ` [PATCH] atm: clip causes unregister hang Herbert Xu
2006-04-14 22:07 ` David S. Miller
2006-04-13 22:22 ` [PATCH 1/4] clip: run through Lindent Stephen Hemminger
2006-04-13 22:24 ` [PATCH 4/4] clip: add module info Stephen Hemminger
2006-04-13 22:45 ` [stable] [PATCH 1/4] clip: run through Lindent Greg KH
2006-04-14 9:01 ` David S. Miller
2006-04-14 22:58 ` David S. Miller
2006-04-14 22:59 ` David S. Miller
[not found] ` <20060413151945.0f181d04@localhost.localdomain>
2006-04-13 22:23 ` [PATCH 3/4] clip: notifier related cleanups Stephen Hemminger
2006-04-13 22:23 ` [PATCH 2/4] clip: get rid of PROC_FS ifdef Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaek01p4j6.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).