From: Roland Dreier <rdreier@cisco.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jie Yang <Jie.Yang@Atheros.com>,
"jeff\@garzik.org" <jeff@garzik.org>,
David Miller <davem@davemloft.net>,
"jcliburn\@gmail.com" <jcliburn@gmail.com>,
"parag.warudkar\@gmail.com" <parag.warudkar@gmail.com>,
Willy Tarreau <w@1wt.eu>,
"oliver.schuster\@schweigstill.de"
<oliver.schuster@schweigstill.de>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver
Date: Wed, 16 Jul 2008 09:36:24 -0700 [thread overview]
Message-ID: <adafxq9bxbr.fsf@cisco.com> (raw)
In-Reply-To: <20080716085329.03e97b2a@extreme> (Stephen Hemminger's message of "Wed, 16 Jul 2008 08:53:29 -0700")
> Output of checkpatch (scripts/checkpatch.pl in kernel source).
> Personally, I am not a whitespace bigot, and don't think
> all the warnings in checkpatch have to be fixed.
>
> ----------
> ERROR: patch seems to be corrupt (line wrapped?)
> #121: FILE: drivers/net/atl1e/atl1e.h:9:
> ree
>
> WARNING: space prohibited between function name and open parenthesis '('
> #212: FILE: drivers/net/atl1e/atl1e.h:97:
> + _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\
It's kind of pointless to run checkpatch on a corrupted patch (the email
was quoted-printable and you didn't decode it back to text). Of course
it's also better to send non-mangled patches.
- R.
next prev parent reply other threads:[~2008-07-16 16:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 3:28 [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver Jie Yang
2008-07-16 4:15 ` Stephen Hemminger
2008-07-16 9:42 ` Jie Yang
2008-07-16 15:53 ` Stephen Hemminger
2008-07-16 16:36 ` Roland Dreier [this message]
2008-07-17 2:47 ` Jie Yang
2008-07-17 3:30 ` Wei Yongjun
2008-07-17 3:34 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2008-07-17 9:04 jie.yang
2008-07-17 9:31 ` Alexey Dobriyan
2008-07-17 9:41 ` Jie Yang
2008-07-17 15:44 ` Stephen Hemminger
2008-07-17 20:04 ` Mariusz Kozlowski
2008-07-17 20:23 ` Ben Hutchings
2008-07-17 21:37 ` David Miller
2008-07-18 3:37 jie.yang
2008-07-22 23:31 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adafxq9bxbr.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=Jie.Yang@Atheros.com \
--cc=davem@davemloft.net \
--cc=jcliburn@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.schuster@schweigstill.de \
--cc=parag.warudkar@gmail.com \
--cc=shemminger@vyatta.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).