From: Roland Dreier <rdreier@cisco.com>
To: Ramachandra K <ramachandra.kuchimanchi@qlogic.com>
Cc: netdev@vger.kernel.org, poornima.kamath@qlogic.com,
general@lists.openfabrics.org, amar.mudrankit@qlogic.com
Subject: [ofa-general] Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction
Date: Tue, 13 May 2008 13:40:52 -0700 [thread overview]
Message-ID: <adafxsmj5t7.fsf@cisco.com> (raw)
In-Reply-To: <20080430171855.31725.89658.stgit@localhost.localdomain> (Ramachandra K.'s message of "Wed, 30 Apr 2008 22:48:55 +0530")
> +#include <rdma/ib_cache.h>
> + ret = ib_find_cached_pkey(viport_config->ibdev,
> + viport_config->port,
> + be16_to_cpu(viport_config->path_info.path.
> + pkey),
> + &attr->pkey_index);
I think this can just be replaced with ib_find_pkey()... there is a call
to kmalloc(... GFP_KERNEL) just a couple of lines about, so you are in a
context where sleeping is allowed. As I said before we want to get rid
of the caching infrastructure so please don't add new users.
next prev parent reply other threads:[~2008-05-13 20:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 17:15 [ofa-general] [PATCH 00/13] QLogic Virtual NIC (VNIC) Driver Ramachandra K
2008-04-30 17:16 ` [ofa-general] [PATCH 01/13] QLogic VNIC: Driver - netdev implementation Ramachandra K
2008-05-02 18:15 ` Roland Dreier
2008-05-05 15:36 ` [ofa-general] " Ramachandra K
2008-05-05 20:42 ` Roland Dreier
2008-04-30 17:16 ` [ofa-general] [PATCH 02/13] QLogic VNIC: Netpath - abstraction of connection to EVIC/VEx Ramachandra K
2008-04-30 17:17 ` [ofa-general] [PATCH 03/13] QLogic VNIC: Implementation of communication protocol with EVIC/VEx Ramachandra K
2008-04-30 17:17 ` [ofa-general] [PATCH 04/13] QLogic VNIC: Implementation of Control path of communication protocol Ramachandra K
2008-04-30 17:18 ` [ofa-general] [PATCH 05/13] QLogic VNIC: Implementation of Data " Ramachandra K
2008-04-30 17:18 ` [ofa-general] [PATCH 06/13] QLogic VNIC: IB core stack interaction Ramachandra K
2008-05-13 20:40 ` Roland Dreier [this message]
2008-04-30 17:19 ` [ofa-general] [PATCH 07/13] QLogic VNIC: Handling configurable parameters of the driver Ramachandra K
2008-05-13 20:41 ` Roland Dreier
2008-04-30 17:19 ` [ofa-general] [PATCH 08/13] QLogic VNIC: sysfs interface implementation for " Ramachandra K
2008-05-01 14:56 ` Stephen Hemminger
2008-05-01 16:02 ` [ofa-general] " Kuchimanchi, Ramachandra (Contractor - )
2008-05-01 16:43 ` [ofa-general] [RESEND] " Ramachandra K
2008-05-01 18:22 ` [ofa-general] " Stephen Hemminger
2008-04-30 17:20 ` [ofa-general] [PATCH 09/13] QLogic VNIC: IB Multicast for Ethernet broadcast/multicast Ramachandra K
2008-05-15 22:38 ` Roland Dreier
2008-04-30 17:20 ` [ofa-general] [PATCH 10/13] QLogic VNIC: Driver Statistics collection Ramachandra K
2008-05-15 22:33 ` Roland Dreier
2008-05-20 16:52 ` [ofa-general] " Ramachandra K
2008-04-30 17:21 ` [PATCH 11/13] QLogic VNIC: Driver utility file - implements various utility macros Ramachandra K
2008-05-01 14:58 ` [ofa-general] " Stephen Hemminger
2008-05-01 16:18 ` [ofa-general] " Kuchimanchi, Ramachandra (Contractor - )
2008-05-01 17:01 ` Ramachandra K
2008-05-01 18:26 ` Stephen Hemminger
2008-04-30 17:21 ` [ofa-general] [PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile Ramachandra K
2008-05-15 22:31 ` Roland Dreier
2008-04-30 17:22 ` [ofa-general] [PATCH 13/13] QLogic VNIC: Modifications to IB " Ramachandra K
2008-04-30 22:25 ` [ofa-general] Re: [PATCH 00/13] QLogic Virtual NIC (VNIC) Driver Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adafxsmj5t7.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=amar.mudrankit@qlogic.com \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=poornima.kamath@qlogic.com \
--cc=ramachandra.kuchimanchi@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).