netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: netdev@vger.kernel.org
Cc: iommu@lists.linux-foundation.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: Any ideas about a crash on reboot with igb and intel_iommu?
Date: Fri, 02 Apr 2010 11:13:03 -0700	[thread overview]
Message-ID: <adahbnt7mfk.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <adabpe3f3c4.fsf@roland-alpha.cisco.com> (Roland Dreier's message of "Thu, 01 Apr 2010 11:13:47 -0700")

So actually I found the following change that went into 2.6.31:

    commit 91615f765a2935b6cbae424b9eee1585ed681ae6
    Author: Jesse Brandeburg <jesse.brandeburg@intel.com>
    Date:   Tue Jun 30 12:45:15 2009 +0000

        igb: fix unmap length bug
        
        driver was mixing NET_IP_ALIGN count bytes in map/unmap calls
        unevenly. Only map the bytes that the hardware might dma into

igb in 2.6.30.y is doing pci_map_single(<some length>) and doing
pci_unmap_single(<some other length>).

However I haven't been able to provoke the crash yet, even by bouncing
an igb interface (with VT-d turned on and with CONFIG_DMAR_DEFAULT_ON enabled).
Does this make sense as the sort of thing that might corrupt the iova
rbtree and lead to a crash in the __free_iova / rb_erase code?

Thanks,
  Roland
-- 
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html

      parent reply	other threads:[~2010-04-02 18:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 18:13 Any ideas about a crash on reboot with igb and intel_iommu? Roland Dreier
2010-04-01 22:45 ` Roland Dreier
2010-04-02 18:13 ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adahbnt7mfk.fsf@roland-alpha.cisco.com \
    --to=rdreier@cisco.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).