From: Roland Dreier <rdreier@cisco.com>
To: Scott Feldman <scofeldm@cisco.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc
Date: Mon, 25 Aug 2008 15:36:21 -0700 [thread overview]
Message-ID: <adaiqtolo2i.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0808251121150.3972@palito_client100.nuovasystems.com> (Scott Feldman's message of "Mon, 25 Aug 2008 11:26:41 -0700 (PDT)")
Oh yeah, by the way, this patch got whitespace mangled somehow so it
won't apply (and also it seems to be against an old tree that doesn't
have the atl1e driver merged).
And:
> +config ENIC
> + tristate "Cisco 10Gigabit Ethernet NIC"
The Kconfig file seems to use "10 Gigabit Ethernet" (with a space) or
variations on "10Gb Ethernet". Probably worth it not to add yet another
variation.
> + depends on PCI
> + select INET_LRO
I believe if you select INET_LRO, you'd better depend on INET or else it
is possible to create unbuildable configs.
next prev parent reply other threads:[~2008-08-25 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 18:26 [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc Scott Feldman
2008-08-25 22:27 ` Roland Dreier
2008-08-26 17:42 ` Scott Feldman
2008-08-25 22:36 ` Roland Dreier [this message]
2008-08-26 17:53 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaiqtolo2i.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).