netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Rick Jones <rick.jones2@hp.com>
Cc: Ben Greear <greearb@candelatech.com>,
	David Miller <davem@davemloft.net>,
	hadi@cyberus.ca, kaber@trash.net, netdev@vger.kernel.org,
	mcarlson@broadcom.com
Subject: Re: RFC: on [ab]use of skb->cb by VLAN code
Date: Tue, 31 Jul 2007 10:50:15 -0700	[thread overview]
Message-ID: <adair80o42w.fsf@cisco.com> (raw)
In-Reply-To: <46AF69C7.1090504@hp.com> (Rick Jones's message of "Tue, 31 Jul 2007 09:56:39 -0700")

 > > Do we really need an 'unsigned int' for mac_len?  Maybe we could use
 > > a 16-bit counter here, and then use the other 16 bits for the VLAN bits?
 > 
 > Not knowing exactly if/how it interacts with that specific field I
 > will point-out that IPoIB in OFED 1.2 just took their MTU to 65520.
 > While that doesn't break the bitbank it does get rather close.

Leaving aside OFED releases, the IPoIB connected mode code in the
standard kernel also allows the MTU to go up to 65520.  And there's
nothing magic about that value -- we could easily do bigger packets.

However, this is irrelevant for two reasons: mac_len is the length of
the LL header, not the packet overall, *and* mac_len is already 16
bits as of commit 334a8132.

 - R.

      reply	other threads:[~2007-07-31 17:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-31  0:59 RFC: on [ab]use of skb->cb by VLAN code jamal
2007-07-31  1:33 ` David Miller
2007-07-31  2:02   ` jamal
2007-07-31  2:06     ` David Miller
2007-07-31  4:30       ` Ben Greear
2007-07-31  5:18         ` David Miller
2007-07-31  5:33           ` Ben Greear
2007-07-31 16:56             ` Rick Jones
2007-07-31 17:50               ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adair80o42w.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=davem@davemloft.net \
    --cc=greearb@candelatech.com \
    --cc=hadi@cyberus.ca \
    --cc=kaber@trash.net \
    --cc=mcarlson@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).