netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: cl@linux-foundation.org, netdev@vger.kernel.org, yosefe@Voltaire.COM
Subject: Re: IPoIB: Fix multicast packet drops before join is complete
Date: Tue, 09 Jun 2009 13:52:45 -0700	[thread overview]
Message-ID: <adaocsx3zaa.fsf@cisco.com> (raw)
In-Reply-To: <20090608.142927.122160930.davem@davemloft.net> (David Miller's message of "Mon, 08 Jun 2009 14:29:27 -0700 (PDT)")


 > > Maybe we need a different approach but (since we are at the point of
 > > talking about categorical fundamentally wrong statements) its
 > > fundamentally wrong if the IPoIB layer works differently from a regular
 > > Ethernet NIC. They should work in the same way.
 > 
 > This I agree on.  When a multicast group is joined, the IPoIB layer
 > should block in some way until the subscription is fully available
 > for use.

Not sure I understand.  What do you mean by block?  It is quite possible
that a single multicast group is waiting to be joined, while other
multicast groups and unicast traffic can be sent with no problem.  So
stopping the whole device queue and blocking everything doesn't seem
appropriate.

 - R.

  reply	other threads:[~2009-06-09 20:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 14:49 IPoIB: Fix multicast packet drops before join is complete Christoph Lameter
2009-06-04  5:41 ` David Miller
2009-06-04 14:28   ` Or Gerlitz
2009-06-04 15:52   ` Christoph Lameter
2009-06-04 22:30     ` David Miller
2009-06-05 14:18       ` Christoph Lameter
2009-06-05 16:56         ` Roland Dreier
2009-06-05 19:17           ` Christoph Lameter
2009-06-05 21:12             ` Roland Dreier
2009-06-06  1:17               ` David Miller
2009-06-05 21:13             ` Roland Dreier
2009-06-08 15:16               ` Christoph Lameter
2009-06-06  1:16         ` David Miller
2009-06-08 15:20           ` Christoph Lameter
2009-06-08 21:29             ` David Miller
2009-06-09 20:52               ` Roland Dreier [this message]
2009-06-10  0:45                 ` David Miller
2009-06-10  3:55                   ` Roland Dreier
2009-06-10  4:57                     ` David Miller
2009-06-10  5:04                       ` Roland Dreier
2009-06-10  5:12                         ` David Miller
2009-06-10 10:18                           ` Or Gerlitz
2009-06-10 12:01                             ` David Miller
2009-06-11 11:45                               ` Or Gerlitz
2009-06-11 11:57                                 ` David Miller
2009-06-11 15:07                       ` Christoph Lameter
2009-06-11 23:58                         ` David Miller
2009-06-12 14:17                           ` Christoph Lameter
2009-06-05 16:54       ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaocsx3zaa.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=cl@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yosefe@Voltaire.COM \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).