From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: [ofa-general] Re: [PATCH 20/21] RDS: Kconfig and Makefile Date: Wed, 28 Jan 2009 21:14:27 -0800 Message-ID: References: <1233022678-9259-1-git-send-email-andy.grover@oracle.com> <1233022678-9259-21-git-send-email-andy.grover@oracle.com> <4981123E.2060406@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, rds-devel@oss.oracle.com, general@lists.openfabrics.org To: Andy Grover Return-path: In-Reply-To: <4981123E.2060406@oracle.com> (Andy Grover's message of "Wed, 28 Jan 2009 18:19:42 -0800") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: general-bounces@lists.openfabrics.org Errors-To: general-bounces@lists.openfabrics.org List-Id: netdev.vger.kernel.org > So the solution is just to base debug message output on a variable, > instead of a config option? RDS actually does do this a little already, > so converting totally isn't hard. I hadn't seen mention this was > preferable -- indeed, tons of drivers and subsystems have options for > compile-time debug statements, should these be converted? My experience is definitely that compile-time switches are a big pain when you actually have to debug something that can only be reproduced on someone else's setup (which will happen once users start using your stuff). You probably can use the dynamic_printk stuff that went in recently to make this all very clean and standard. - R.