netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Ramachandra K" <ramachandra.kuchimanchi@qlogic.com>
Cc: netdev@vger.kernel.org, poornima.kamath@qlogic.com,
	general@lists.openfabrics.org, amar.mudrankit@qlogic.com
Subject: Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile.
Date: Mon, 26 May 2008 14:47:29 -0700	[thread overview]
Message-ID: <adaod6s4u1a.fsf@cisco.com> (raw)
In-Reply-To: <71d336490805260037y4c45abd5lccd5dbadebd84eb8@mail.gmail.com> (Ramachandra K.'s message of "Mon, 26 May 2008 13:07:28 +0530")

 > The debugging code is always compiled in and is controlled
 > at run time through vnic_debug module parameter.
 > INFINIBAND_QLGC_VNIC_DEBUG config option only controls verbose debugging
 > which adds some extra information in the debug statements (file name,
 > line number)
 > which we typically use for debug builds of the driver.  Even if this option is
 > set to 'n', users can still get all debug messages from the driver by using the
 > vnic_debug module parameter.

OK, I looked at the code.  Is there any point to having
CONFIG_INFINIBAND_QLGC_VNIC_DEBUG at all??  Is anyone going to care
about having __FILE__ and __LINE__ included in the output and want to
set this option to 'n'?

 - R.

  reply	other threads:[~2008-05-26 21:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-19 10:31 [ofa-general] [PATCH v2 00/13] QLogic VNIC Driver Ramachandra K
2008-05-19 10:31 ` [ofa-general] [PATCH v2 01/13] QLogic VNIC: Driver - netdev implementation Ramachandra K
2008-05-19 10:32 ` [ofa-general] [PATCH v2 02/13] QLogic VNIC: Netpath - abstraction of connection to EVIC/VEx Ramachandra K
2008-05-19 10:32 ` [ofa-general] [PATCH v2 03/13] QLogic VNIC: Implementation of communication protocol with EVIC/VEx Ramachandra K
2008-05-28  5:28   ` [ofa-general] " Roland Dreier
2008-05-28 14:18     ` Ramachandra K
2008-05-19 10:33 ` [ofa-general] [PATCH v2 04/13] QLogic VNIC: Implementation of Control path of communication protocol Ramachandra K
2008-05-19 10:33 ` [ofa-general] [PATCH v2 05/13] QLogic VNIC: Implementation of Data " Ramachandra K
2008-05-19 10:34 ` [ofa-general] [PATCH v2 06/13] QLogic VNIC: IB core stack interaction Ramachandra K
2008-05-19 10:34 ` [ofa-general] [PATCH v2 07/13] QLogic VNIC: Handling configurable parameters of the driver Ramachandra K
2008-05-19 10:35 ` [PATCH v2 08/13] QLogic VNIC: sysfs interface implementation for " Ramachandra K
2008-05-28  5:26   ` [ofa-general] " Roland Dreier
2008-05-19 10:35 ` [ofa-general] [PATCH v2 09/13] QLogic VNIC: IB Multicast for Ethernet broadcast/multicast Ramachandra K
2008-05-19 10:36 ` [ofa-general] [PATCH v2 10/13] QLogic VNIC: Driver Statistics collection Ramachandra K
2008-05-19 10:37 ` [PATCH v2 11/13] QLogic VNIC: Driver utility file - implements various utility macros Ramachandra K
2008-05-19 10:37 ` [ofa-general] [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile Ramachandra K
2008-05-25 22:43   ` [ofa-general] " Roland Dreier
2008-05-26  7:37     ` Ramachandra K
2008-05-26 21:47       ` Roland Dreier [this message]
2008-05-27  6:23         ` Ramachandra K
2008-05-27 18:26           ` Roland Dreier
2008-05-19 10:38 ` [ofa-general] [PATCH v2 13/13] QLogic VNIC: Modifications to IB " Ramachandra K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaod6s4u1a.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=amar.mudrankit@qlogic.com \
    --cc=general@lists.openfabrics.org \
    --cc=netdev@vger.kernel.org \
    --cc=poornima.kamath@qlogic.com \
    --cc=ramachandra.kuchimanchi@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).