From: Roland Dreier <rdreier@cisco.com>
To: Scott Feldman <scofeldm@cisco.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc
Date: Mon, 25 Aug 2008 15:27:57 -0700 [thread overview]
Message-ID: <adaprnwlogi.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0808251121150.3972@palito_client100.nuovasystems.com> (Scott Feldman's message of "Mon, 25 Aug 2008 11:26:41 -0700 (PDT)")
Overall, looks quite good. Very clean, just a few comments here and there:
> +#define PCI_VENDOR_ID_CISCO 0x1137
> +#define PCI_DEVICE_ID_CISCO_ENIC 0x0043
the current convention is that we don't put IDs that are only used in
one place into pci_ids.h. I guess the vendor ID can stay but the device
ID is probably not needed here (just put it in the driver file where
it's used, if anywhere).
- R.
next prev parent reply other threads:[~2008-08-25 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 18:26 [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc Scott Feldman
2008-08-25 22:27 ` Roland Dreier [this message]
2008-08-26 17:42 ` Scott Feldman
2008-08-25 22:36 ` Roland Dreier
2008-08-26 17:53 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaprnwlogi.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).