From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: [ofa-general] Re: [PATCH v2 08/13] QLogic VNIC: sysfs interface implementation for the driver Date: Tue, 27 May 2008 22:26:04 -0700 Message-ID: References: <20080519102843.12355.832.stgit@localhost.localdomain> <20080519103529.12355.82570.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, poornima.kamath@qlogic.com, general@lists.openfabrics.org, amar.mudrankit@qlogic.com To: Ramachandra K Return-path: In-Reply-To: <20080519103529.12355.82570.stgit@localhost.localdomain> (Ramachandra K.'s message of "Mon, 19 May 2008 16:05:29 +0530") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: general-bounces@lists.openfabrics.org Errors-To: general-bounces@lists.openfabrics.org List-Id: netdev.vger.kernel.org > +ssize_t vnic_create_primary(struct device *dev, > + struct device_attribute *dev_attr, const char *buf, > + size_t count) > +ssize_t vnic_create_secondary(struct device *dev, > + struct device_attribute *dev_attr, > + const char *buf, size_t count) > +ssize_t vnic_delete(struct device *dev, struct device_attribute *dev_attr, > + const char *buf, size_t count) These are all only referenced from a sysfs attribute defined in the same file, so they can be made static (and don't need extern declarations in a header file).