From: Roland Dreier <rdreier@cisco.com>
To: akpm@osdl.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, rdunlap@xenotime.net
Subject: Re: [patch 3/5] ATM: he: fix section mismatch
Date: Tue, 19 Sep 2006 23:05:08 -0700 [thread overview]
Message-ID: <adaslinjcob.fsf@cisco.com> (raw)
In-Reply-To: <200609200108.k8K18oW2011719@shell0.pdx.osdl.net> (akpm@osdl.org's message of "Tue, 19 Sep 2006 18:08:50 -0700")
> WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from .text between 'he_start' (at offset 0x218a) and 'he_service_tbrq'
> -static int __init
> +static int __devinit
> he_init_group(struct he_dev *he_dev, int group)
There are a ton of other __init functions (he_init_irq(),
he_init_tx_lbfp(), etc.) called from the __devinit function he_start()
in this driver. So I think this patch is insufficient -- does it even
really fix the warning?? (I think -funit-at-a-time hides the warning
with this patch on x86-64)
Anyway, I sent a more comprehensive fix to Chas who forwarded it to
DaveM already.
- R.
prev parent reply other threads:[~2006-09-20 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 1:08 [patch 3/5] ATM: he: fix section mismatch akpm
2006-09-20 6:05 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaslinjcob.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).