* [patch 3/5] ATM: he: fix section mismatch
@ 2006-09-20 1:08 akpm
2006-09-20 6:05 ` Roland Dreier
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2006-09-20 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, rdunlap
From: Randy Dunlap <rdunlap@xenotime.net>
WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from .text between 'he_start' (at offset 0x218a) and 'he_service_tbrq'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/atm/he.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/atm/he.c~atm-he-fix-section-mismatch drivers/atm/he.c
--- a/drivers/atm/he.c~atm-he-fix-section-mismatch
+++ a/drivers/atm/he.c
@@ -785,7 +785,7 @@ he_init_cs_block_rcm(struct he_dev *he_d
return 0;
}
-static int __init
+static int __devinit
he_init_group(struct he_dev *he_dev, int group)
{
int i;
_
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch 3/5] ATM: he: fix section mismatch
2006-09-20 1:08 [patch 3/5] ATM: he: fix section mismatch akpm
@ 2006-09-20 6:05 ` Roland Dreier
0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2006-09-20 6:05 UTC (permalink / raw)
To: akpm; +Cc: davem, netdev, rdunlap
> WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from .text between 'he_start' (at offset 0x218a) and 'he_service_tbrq'
> -static int __init
> +static int __devinit
> he_init_group(struct he_dev *he_dev, int group)
There are a ton of other __init functions (he_init_irq(),
he_init_tx_lbfp(), etc.) called from the __devinit function he_start()
in this driver. So I think this patch is insufficient -- does it even
really fix the warning?? (I think -funit-at-a-time hides the warning
with this patch on x86-64)
Anyway, I sent a more comprehensive fix to Chas who forwarded it to
DaveM already.
- R.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-20 6:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-20 1:08 [patch 3/5] ATM: he: fix section mismatch akpm
2006-09-20 6:05 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).