From: Roland Dreier <rdreier@cisco.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
shemminger@vyatta.com, jeff@garzik.org, netdev@vger.kernel.org,
davem@davemloft.net, mpm@selenic.com
Subject: Re: [patch 12/12] Configure out ethtool support
Date: Wed, 30 Jul 2008 16:35:12 -0700 [thread overview]
Message-ID: <adatze7x7wv.fsf@cisco.com> (raw)
In-Reply-To: <20080730150454.7612912f.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 30 Jul 2008 15:04:54 -0700")
> I don't really trust allnoconfig as a way of determining size changes.
> It can easily be the case that kernel A's allnoconfig happens to pull
> in more stuff than kernel B's allnoconfig.
>
> So I do think that one should dive into the details and verify that
> particular size changes really are due to unavoidable code bloat,
> rather than being due to some unfortunate Kconfig change.
The following is rather squishy, but... when I've looked at the growth
of various bits of the kernel over time, a good bit of the growth comes
from changes like "add handling for undeniably useful feature X" or "add
handling of error condition Y." And it's 50 bytes here, 100 bytes
there, and all the changes make sense and are too small to make
configurable. So being able to get 6K all at once from ethtool is
actually pretty good, although probably not quite good enough to merge.
I really don't know what the right answer is to all of this.
next prev parent reply other threads:[~2008-07-30 23:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 19:39 [patch 12/12] Configure out ethtool support akpm
2008-07-30 20:37 ` Stephen Hemminger
2008-07-30 20:48 ` Thomas Petazzoni
2008-07-30 21:01 ` Stephen Hemminger
2008-07-30 21:35 ` Thomas Petazzoni
2008-07-30 21:48 ` Andrew Morton
2008-07-30 21:52 ` Thomas Petazzoni
2008-07-30 22:04 ` Andrew Morton
2008-07-30 23:35 ` Roland Dreier [this message]
2008-07-30 21:57 ` David Miller
2008-07-30 22:13 ` Andrew Morton
2008-07-30 22:33 ` David Miller
2008-07-31 10:39 ` David Woodhouse
2008-07-31 10:43 ` David Miller
2008-07-31 10:49 ` David Woodhouse
2008-07-31 10:47 ` David Miller
2008-07-31 15:36 ` Matt Mackall
2008-07-31 15:59 ` Stephen Hemminger
2008-07-31 16:11 ` Matt Mackall
2008-07-31 18:17 ` Evgeniy Polyakov
2008-07-30 21:35 ` David Miller
2008-07-30 21:44 ` Andrew Morton
2008-07-30 22:24 ` Matt Mackall
2008-07-30 22:37 ` David Miller
2008-07-30 23:05 ` Matt Mackall
2008-07-30 23:21 ` David Miller
2008-07-31 1:10 ` Matt Mackall
2008-07-31 1:23 ` David Miller
2008-07-31 10:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adatze7x7wv.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).