netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ofa-general] [PATCH] amso1100: QP init bug in amso driver
@ 2007-07-24 19:31 Tom Tucker
  2007-07-29  3:09 ` [ofa-general] " Roland Dreier
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Tucker @ 2007-07-24 19:31 UTC (permalink / raw)
  To: Roland Dreier; +Cc: netdev, OpenFabrics General

Roland:

The guys at UNH found this and fixed it. I'm surprised no
one has hit this before. I guess it only breaks when the 
refcount on the QP is non-zero.

Initialize the wait_queue_head_t in the c2_qp structure.

Signed-off-by: Ethan Burns <eaburns@iol.unh.edu>
Acked-by: Tom Tucker <tom@opengridcomputing.com>

---
 drivers/infiniband/hw/amso1100/c2_qp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/amso1100/c2_qp.c b/drivers/infiniband/hw/amso1100/c2_qp.c
index 420c138..01d0786 100644
--- a/drivers/infiniband/hw/amso1100/c2_qp.c
+++ b/drivers/infiniband/hw/amso1100/c2_qp.c
@@ -506,6 +506,7 @@ int c2_alloc_qp(struct c2_dev *c2dev,
 	qp->send_sgl_depth = qp_attrs->cap.max_send_sge;
 	qp->rdma_write_sgl_depth = qp_attrs->cap.max_send_sge;
 	qp->recv_sgl_depth = qp_attrs->cap.max_recv_sge;
+	init_waitqueue_head(&qp->wait);
 
 	/* Initialize the SQ MQ */
 	q_size = be32_to_cpu(reply->sq_depth);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [ofa-general] Re: [PATCH] amso1100: QP init bug in amso driver
  2007-07-24 19:31 [ofa-general] [PATCH] amso1100: QP init bug in amso driver Tom Tucker
@ 2007-07-29  3:09 ` Roland Dreier
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2007-07-29  3:09 UTC (permalink / raw)
  To: Tom Tucker; +Cc: netdev, OpenFabrics General

thanks, applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-07-29  3:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-24 19:31 [ofa-general] [PATCH] amso1100: QP init bug in amso driver Tom Tucker
2007-07-29  3:09 ` [ofa-general] " Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).