From: Roland Dreier <rdreier@cisco.com>
To: ggrundstrom@neteffect.com
Cc: netdev@vger.kernel.org, ewg@lists.openfabrics.org,
general@lists.openfabrics.org
Subject: Re: [ofa-general] [PATCH 14/14 v2] nes: kernel build infrastructure
Date: Sun, 21 Oct 2007 19:22:27 -0700 [thread overview]
Message-ID: <adave8z99cs.fsf@cisco.com> (raw)
In-Reply-To: <200710192028.l9JKSnZG021867@neteffect.com> (ggrundstrom@neteffect.com's message of "Fri, 19 Oct 2007 15:28:49 -0500")
> +
> +EXTRA_CFLAGS += -DNES_MINICM
I don't see anyplace NES_MINICM is used. Delete this line?
> +
> +obj-$(CONFIG_INFINIBAND_NES) += iw_nes.o
> +
> +iw_nes-objs := nes.o nes_hw.o nes_nic.o nes_utils.o nes_verbs.o nes_cm.o
> +
Also the file has an extra blank line at the beginning and end. Might
as well kill them.
prev parent reply other threads:[~2007-10-22 2:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 20:28 [ofa-general] [PATCH 14/14 v2] nes: kernel build infrastructure ggrundstrom
2007-10-22 2:22 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adave8z99cs.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=ewg@lists.openfabrics.org \
--cc=general@lists.openfabrics.org \
--cc=ggrundstrom@neteffect.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).