From: Roland Dreier <rdreier@cisco.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
Liran Liss <liranl@mellanox.co.il>,
tziporet@mellanox.co.il
Subject: Re: [PATCH RFC 02/10] mlx4_en: Device initialization
Date: Tue, 15 Jul 2008 12:21:51 -0700 [thread overview]
Message-ID: <adawsjndkc0.fsf@cisco.com> (raw)
In-Reply-To: <487B6571.8000602@mellanox.co.il> (Yevgeny Petrilin's message of "Mon, 14 Jul 2008 17:40:49 +0300")
> + /* Create a netdev for each port */
> + mlx4_foreach_port(i, mdev->ports_map) {
> + mlx4_info(mdev, "Activating port:%d\n", i);
> + if (mlx4_en_init_netdev(mdev, i, &mdev->profile.prof[i])) {
> + mdev->pndev[i] = NULL;
> + goto err_free_netdev;
> + }
> + }
> + return mdev;
> +
> +
> +err_free_netdev:
> + for (i = 0; i < dev->caps.num_ports; i++) {
> + if (mdev->pndev[i])
> + mlx4_en_destroy_netdev(mdev->pndev[i]);
> + }
There's a strange asymmetry between the mlx4_foreach_port() loop and the
for () loop here.
prev parent reply other threads:[~2008-07-15 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 14:40 [PATCH RFC 02/10] mlx4_en: Device initialization Yevgeny Petrilin
2008-07-14 16:48 ` Ben Hutchings
2008-07-15 19:21 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adawsjndkc0.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=jeff@garzik.org \
--cc=liranl@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=tziporet@mellanox.co.il \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).