From: Roland Dreier <rdreier@cisco.com>
To: ggrundstrom@neteffect.com
Cc: netdev@vger.kernel.org, ewg@lists.openfabrics.org,
general@lists.openfabrics.org
Subject: [ofa-general] Re: [PATCH 11/14 v2] nes: OpenFabrics kernel verbs
Date: Wed, 31 Oct 2007 13:56:04 -0700 [thread overview]
Message-ID: <adawst3f1gb.fsf@cisco.com> (raw)
In-Reply-To: <200710192023.l9JKNFov021830@neteffect.com> (ggrundstrom@neteffect.com's message of "Fri, 19 Oct 2007 15:23:15 -0500")
> +/**
> + * nes_post_send
> + */
> +static int nes_post_send(struct ib_qp *ibqp, struct ib_send_wr *ib_wr,
> + struct ib_send_wr **bad_wr)
> ...
> + switch (ib_wr->opcode) {
> ...
> + if (ib_wr->num_sge > nesdev->nesadapter->max_sge) {
> + err = -EINVAL;
> + break;
> + }
> ...
> + default:
> + /* error */
> + err = -EINVAL;
> + break;
looks like if you detect an error while posting a work request, you
break out of the switch statement but just continue through the while
loop going through the list of work reuqests. Which doesn't seem like
it will work very well.
prev parent reply other threads:[~2007-10-31 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 20:23 [ofa-general] [PATCH 11/14 v2] nes: OpenFabrics kernel verbs ggrundstrom
2007-10-31 20:56 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adawst3f1gb.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=ewg@lists.openfabrics.org \
--cc=general@lists.openfabrics.org \
--cc=ggrundstrom@neteffect.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).