netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: xma@us.ibm.com, hadi@cyberus.ca, jgarzik@pobox.com,
	netdev@vger.kernel.org, netdev-owner@vger.kernel.org,
	rusty@rustcorp.com.au, shemminger@linux-foundation.org
Subject: Re: [PATCH RFC]: napi_struct V5
Date: Thu, 09 Aug 2007 10:49:35 -0700	[thread overview]
Message-ID: <adawsw4mwcw.fsf@cisco.com> (raw)
In-Reply-To: <20070808.152059.101495015.davem@davemloft.net> (David Miller's message of "Wed, 08 Aug 2007 15:20:59 -0700 (PDT)")

 > > Dave, could you please hold this portion of the patch for a moment. I will
 > > test this patch ASAP. According to our previous experience, this changes
 > > significant changes some IPoIB driver performance.
 > 
 > I reverted everything Roland had an issue with, I got tired of arguing
 > my position and doing all of the coding too.  He won.

Why does this have to become a contest of wills where someone wins?  I
wish we could just have a technical discussion and get to the best
solution.  You posted an RFC, and I commented on the parts where I
believe I have some expertise.  We're all on the same side here.

Shirley, I think it would still be useful to run benchmarks of IPoIB
on ehca with Dave's NAPI patches, both V5 that changed the "missed
event" behavior and V6 that didn't.  At least I'm curious to know how
much the difference is.

 - R.

  parent reply	other threads:[~2007-08-09 17:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06  6:24 [PATCH RFC]: napi_struct V5 David Miller
2007-08-06 18:00 ` Michael Chan
2007-08-06 20:50   ` David Miller
2007-08-07 12:52 ` jamal
2007-08-08  0:59   ` David Miller
2007-08-08 12:10     ` jamal
2007-08-09  4:35       ` David Miller
2007-08-07 22:37 ` Roland Dreier
2007-08-07 23:06   ` David Miller
2007-08-08  3:56     ` Roland Dreier
2007-08-08  4:08       ` David Miller
     [not found]     ` <OFA2F18805.38AA0BD0-ON87257331.005367FB-88257331.0027BEED@us.ibm.com>
2007-08-08 15:32       ` jamal
2007-08-09  4:23         ` David Miller
2007-08-09  5:32           ` Jeff Garzik
2007-08-09 16:58         ` Roland Dreier
2007-08-10 13:55           ` jamal
2007-08-10 21:39             ` David Miller
2007-08-13 21:47             ` Roland Dreier
2007-08-08 22:20       ` David Miller
2007-08-08 23:23         ` Shirley Ma
2007-08-09 17:49         ` Roland Dreier [this message]
2007-08-09 18:16           ` Shirley Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adawsw4mwcw.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=jgarzik@pobox.com \
    --cc=netdev-owner@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=shemminger@linux-foundation.org \
    --cc=xma@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).