From: Roland Dreier <rdreier@cisco.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
liranl@mellanox.co.il, tziporet@mellanox.co.il
Subject: Re: [PATCH 16/25] mlx4_core: boot sriov
Date: Wed, 04 Nov 2009 11:55:49 -0800 [thread overview]
Message-ID: <aday6mmyshm.fsf@cisco.com> (raw)
In-Reply-To: <4AF19E5D.1060806@mellanox.co.il> (Yevgeny Petrilin's message of "Wed, 04 Nov 2009 17:31:41 +0200")
> + /* Detect if this device is a virtual function */
> + switch (id->device) {
> + case 0x6341:
> + case 0x634b:
> + case 0x6733:
> + case 0x673d:
> + case 0x6369:
> + case 0x6751:
> + case 0x6765:
This isn't be maintainable or sane. How about using driver_data in the
PCI device table?
> +#ifdef CONFIG_PCI_IOV
> + if (sr_iov) {
Can we avoid a lot of these ifdefs by just doing
#else
#define sr_iov 0
#endif /* CONFIG_PCI_IOV */
at the beginning and letting the IOV code be optimized away?
- R.
next prev parent reply other threads:[~2009-11-04 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 15:31 [PATCH 16/25] mlx4_core: boot sriov Yevgeny Petrilin
2009-11-04 19:55 ` Roland Dreier [this message]
2009-11-05 13:26 ` Liran Liss
[not found] ` <2ED289D4E09FBD4D92D911E869B97FDD0166CA13-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>
2009-11-05 15:57 ` Roland Dreier
2009-11-05 16:21 ` Liran Liss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aday6mmyshm.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=linux-rdma@vger.kernel.org \
--cc=liranl@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=tziporet@mellanox.co.il \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).