From: Roland Dreier <rdreier@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: jesse.brandeburg@intel.com, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, gospo@redhat.com,
alexander.h.duyck@intel.com
Subject: Re: [net-next PATCH 1/3] ixgbe: enable HW RSC for 82599
Date: Wed, 29 Apr 2009 09:40:41 -0700 [thread overview]
Message-ID: <aday6tj1khi.fsf@cisco.com> (raw)
In-Reply-To: <20090428.175446.191949653.davem@davemloft.net> (David Miller's message of "Tue, 28 Apr 2009 17:54:46 -0700 (PDT)")
> > ah, you're right, but this features enables our new hardware that can do
> > LRO in hardware, and then GRO can work on top of it if necessary. We
> > wanted some way to turn it off and overloaded the LRO flag to do so.
> That ugly. And the kernel is going to turn this off on you
> when the user enables either forwarding or bridging.
No comment on ugliness. However it seems like a good feature if the
kernel turns off hardware LRO when forwarding/bridging is turned on --
after all, we don't want the hardware munging wire frames in that case,
for exactly the same reasons that we don't want the kernel LRO munging
frames.
- R.
prev parent reply other threads:[~2009-04-29 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 8:42 [net-next PATCH 1/3] ixgbe: enable HW RSC for 82599 Jeff Kirsher
2009-04-28 8:42 ` [net-next PATCH 2/3] ixgbe: Interrupt management update " Jeff Kirsher
2009-04-28 8:55 ` David Miller
2009-04-28 8:43 ` [net-next PATCH 3/3] ixgbe: Clear out stray tx work on link down Jeff Kirsher
2009-04-28 8:55 ` David Miller
2009-04-28 8:55 ` [net-next PATCH 1/3] ixgbe: enable HW RSC for 82599 David Miller
2009-04-29 0:12 ` Brandeburg, Jesse
2009-04-29 0:54 ` David Miller
2009-04-29 16:16 ` Alexander Duyck
2009-04-29 16:40 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aday6tj1khi.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).