From: Roland Dreier <rdreier@cisco.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, sfr <sfr@canb.auug.org.au>,
rolandd@cisco.com, ericvh@gmail.com,
akpm <akpm@linux-foundation.org>,
davem@davemloft.net, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/9p: limit RDMA to INET
Date: Mon, 03 Nov 2008 12:52:50 -0800 [thread overview]
Message-ID: <aday700v8f1.fsf@cisco.com> (raw)
In-Reply-To: <20081103111731.d12dbb84.randy.dunlap@oracle.com> (Randy Dunlap's message of "Mon, 3 Nov 2008 11:17:31 -0800")
> Make 9p's RDMA option depend on INET since it uses Infiniband rdma_*
> functions and that code depends on INET. Otherwise 9p can try to
> use symbols which don't exist.
>
> ERROR: "rdma_destroy_id" [net/9p/9pnet_rdma.ko] undefined!
Good catch.
> config NET_9P_RDMA
> - depends on NET_9P && INFINIBAND && EXPERIMENTAL
> + depends on INET && INFINIBAND && EXPERIMENTAL
I wonder if there's a way to make this depend on INFINIBAND_ADDR_TRANS
instead of INET, since that's the real dependency to get the rdma_*
symbols. However INFINIBAND_ADDR_TRANS is a bool that gets set to y iff
INET and INFINIBAND are set, so it's not trivial to make a tristate
depend on it.
Maybe this patch is fine as it is, since the Kconfig dependencies are
unlikely to change anyway...
- R.
parent reply other threads:[~2008-11-03 20:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20081103111731.d12dbb84.randy.dunlap@oracle.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aday700v8f1.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rolandd@cisco.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).