* Re: [PATCH] net/9p: limit RDMA to INET
[not found] <20081103111731.d12dbb84.randy.dunlap@oracle.com>
@ 2008-11-03 20:52 ` Roland Dreier
0 siblings, 0 replies; only message in thread
From: Roland Dreier @ 2008-11-03 20:52 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, linux-next, sfr, rolandd, ericvh, akpm, davem, netdev
> Make 9p's RDMA option depend on INET since it uses Infiniband rdma_*
> functions and that code depends on INET. Otherwise 9p can try to
> use symbols which don't exist.
>
> ERROR: "rdma_destroy_id" [net/9p/9pnet_rdma.ko] undefined!
Good catch.
> config NET_9P_RDMA
> - depends on NET_9P && INFINIBAND && EXPERIMENTAL
> + depends on INET && INFINIBAND && EXPERIMENTAL
I wonder if there's a way to make this depend on INFINIBAND_ADDR_TRANS
instead of INET, since that's the real dependency to get the rdma_*
symbols. However INFINIBAND_ADDR_TRANS is a bool that gets set to y iff
INET and INFINIBAND are set, so it's not trivial to make a tristate
depend on it.
Maybe this patch is fine as it is, since the Kconfig dependencies are
unlikely to change anyway...
- R.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-11-03 20:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20081103111731.d12dbb84.randy.dunlap@oracle.com>
2008-11-03 20:52 ` [PATCH] net/9p: limit RDMA to INET Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).