From: Roland Dreier <rdreier@cisco.com>
To: Steve Wise <swise@opengridcomputing.com>
Cc: netdev@vger.kernel.org, general@lists.openfabrics.org,
divy@chelsio.com, jeff@garzik.org, wenxiong@us.ibm.com
Subject: [ofa-general] Re: [PATCH 2.6.28] RDMA/cxgb3: deadlock in iw_cxgb3 can cause hang when configuring interface.
Date: Wed, 12 Nov 2008 10:20:40 -0800 [thread overview]
Message-ID: <adazlk4n6vb.fsf@cisco.com> (raw)
In-Reply-To: <20081106230642.28808.66765.stgit@dell3.ogc.int> (Steve Wise's message of "Thu, 06 Nov 2008 17:06:42 -0600")
Looks good, applied.
However, I think it's a little yucky to call ethtool ops without rtnl,
although it is of course perfectly safe in this case. It might be nicer
to introduce a new cxgb3 <-> iw_cxgb3 interface that returns the
firmware version, which can also be used to implement the get_drvinfo
ethtool op as well. That would let you avoid fw_vers_string_to_u64() as
well -- it is a little silly at the moment how cxgb3 converts to a
string and then iw_cxgb3 parses that string.
But that's all much lower priority than just fixing a deadlock.
- R.
prev parent reply other threads:[~2008-11-12 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 23:06 [ofa-general] [PATCH 2.6.28] RDMA/cxgb3: deadlock in iw_cxgb3 can cause hang when configuring interface Steve Wise
2008-11-06 23:27 ` Divy Le Ray
2008-11-12 18:20 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adazlk4n6vb.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=divy@chelsio.com \
--cc=general@lists.openfabrics.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).