From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A41DE3C061A; Thu, 9 Apr 2026 11:05:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775732725; cv=none; b=eLY/pIK/bR7tEwOqAIemEvObl33mr4o0LeIteYuvytgT1C6qp+M+GiTVvRRhRnHFMNYW4iOqdV/yOwEzczIGYkb7WQ0sCTQAaQrfOWafL/Q0joW2Xys1ciYE6ib8G+xNeWtfhTjyrtj+tXDWxeVDBxG7SiRUgiHOAFW9XsIKCpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775732725; c=relaxed/simple; bh=xuctQlUh1rJz7bux3rwT0Ez1VJZpMZgCAR97C5j81NA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lqDalqJs+kX+pWXi6jOlFyoTmsw61QqnCfA3TzwYctQihJgNrL9ZrtHYdmcjCTbx3fCApy/DHJN5ldH7JPsomb7wN80Nab5aXPkgbAmzx1b77UjjlY5/qiSph/VovTQjDiJanpTYRal2D/YflNFespWEltLTntL4vwP4RDT3ReE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=IAgt7xHz; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="IAgt7xHz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BHnIlM954PbIG8agasHHlF/ONcTjEJKERWp0wyDnQmM=; b=IAgt7xHzUGcLdTg3q8WBwwACt9 LVSAH5tXNNhnHRWh3HX+L1B0OPDF2mTrgOmAqXIwlyn3AY9bR0Eb7Daxk5wdjKUXT14ryRhfiWEOz SRF3SVMGmZ5Qvx9PDDnv7wHLC4voRgyZoDJgg5B8YPV9NEHgMbbyX7zIuhbQkCP3eeA4zV5cun0Oc kYmyNzXoeybWX1Wn2IheeWYZ87E/qH8TmEIS0grdUki7dlNCoEw6CskcG58gh2k1DNGYUbVLQ5KUA utizc1Hli/srEZhUvXOkpCiWaRINEILZyj/NvcJVrla2PggMnl8NlJ4pNOR2XGn/4Boao+gCEYZi5 fH9CFUMg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:32930) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wAnCD-000000003Rb-3tTG; Thu, 09 Apr 2026 12:05:13 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1wAnCB-000000004Kc-3PnC; Thu, 09 Apr 2026 12:05:11 +0100 Date: Thu, 9 Apr 2026 12:05:11 +0100 From: "Russell King (Oracle)" To: Biju Das Cc: Ovidiu Panait , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH net v2 2/2] net: phy: micrel: remove ksz9131_resume() Message-ID: References: <20260409095633.70973-1-ovidiu.panait.rb@renesas.com> <20260409095633.70973-3-ovidiu.panait.rb@renesas.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Thu, Apr 09, 2026 at 10:52:35AM +0000, Biju Das wrote: > Hi Russell King, > > Thanks for the feedback. > > > -----Original Message----- > > From: Russell King > > Sent: 09 April 2026 11:30 > > Subject: Re: [PATCH net v2 2/2] net: phy: micrel: remove ksz9131_resume() > > > > phy_init_hw() will also call drv->config_intr(), so that doesn't need to be done either. > > > > It will also call drv->config_init(), which will call kszphy_config_reset(). > > > > So most of kszphy_resume() becomes unnecessary. I think the only thing that remains would be the call > > to kszphy_enable_clk() - and is it fine to call that after phy_init_hw() ? > > It just needs kszphy_enable_clk() and phydev->drv->config_intr() to enable PHY interrupts for > suspend-to-RAM to work on RZ/G3E SMARC EVK. I think you mean WoL rather than suspend-to-RAM, although I don't see anything in micrel.c that hints that WoL is supported, so please explain why and how the PHY interrupt impacts suspend-to-RAM. Note that a particular interrupt should not wake the system unless enable_irq_wake() has been called for that specific interrupt. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!