From: Breno Leitao <leitao@debian.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Leszek Pepiak <leszek.pepiak@intel.com>
Subject: Re: [PATCH net-next v2] iavf: fix kernel-doc comment style in iavf_ethtool.c
Date: Thu, 9 Apr 2026 05:35:28 -0700 [thread overview]
Message-ID: <adedA3IogGaBhXIQ@gmail.com> (raw)
In-Reply-To: <20260409093020.3808687-1-aleksandr.loktionov@intel.com>
On Thu, Apr 09, 2026 at 11:30:20AM +0200, Aleksandr Loktionov wrote:
> iavf_ethtool.c contains 31 kernel-doc comment blocks using the legacy
> `**/` terminator instead of the correct single `*/`. Two function
> headers also use a colon separator (`iavf_get_channels:`,
> `iavf_set_channels:`) instead of the ` - ` dash required by kernel-doc.
>
> Additionally several comments embed their return-value descriptions in
> the body paragraph, producing `scripts/kernel-doc -Wreturn` warnings.
> Void functions that incorrectly say "Returns ..." are also rephrased.
>
> Fix all issues across the full file:
> - Replace every `**/` terminator with `*/`.
> - Change `function_name:` doc headers to `function_name -`.
> - Move inline "Returns ..." sentences into dedicated `Return:` sections
> for non-void functions (iavf_get_msglevel, iavf_get_rxnfc,
> iavf_set_channels, iavf_get_rxfh_key_size, iavf_get_rxfh_indir_size,
> iavf_get_rxfh, iavf_set_rxfh).
> - Rephrase body descriptions in void functions that incorrectly said
> "Returns ..." (iavf_get_drvinfo, iavf_get_ringparam, iavf_get_coalesce).
> - Remove boilerplate body text for iavf_get_rxfh_key_size and
> iavf_get_rxfh_indir_size; the `Return:` line now conveys the same
> information without the vague "Returns the table size." sentence.
>
> Suggested-by: Anthony L. Nguyen <anthony.l.nguyen@intel.com>
> Suggested-by: Leszek Pepiak <leszek.pepiak@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
prev parent reply other threads:[~2026-04-09 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 9:30 [PATCH net-next v2] iavf: fix kernel-doc comment style in iavf_ethtool.c Aleksandr Loktionov
2026-04-09 12:35 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adedA3IogGaBhXIQ@gmail.com \
--to=leitao@debian.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leszek.pepiak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox