From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: <alexandre.torgue@st.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming
Date: Fri, 2 Dec 2016 10:25:30 +0100 [thread overview]
Message-ID: <adf5823f-97b4-a9d5-19b5-8b4ef63f52a4@st.com> (raw)
In-Reply-To: <20161202085846.GB20128@Red>
On 12/2/2016 9:58 AM, Corentin Labbe wrote:
> On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote:
>> Hello Corentin
>>
>> patches look ok, I just wonder if you tested it in case of
>> the stmmac is connected to a transceiver. Let me consider it
>> a critical part of the driver to properly work.
>>
>> Regards
>> Peppe
>>
>
> I tested it on a Cubieboard 2 (dwmac-sunxi).
> What do you mean by "connected to a transceiver" ? an external PHY ?
yes an external PHY. AFAIK, users have, sometime, a switch
with fixed link enabled.
Thx for your support and patches
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>
> Regards
>
next prev parent reply other threads:[~2016-12-02 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 15:19 [PATCH 1/2] net: stmmac: avoid Camelcase naming Corentin Labbe
2016-12-01 15:19 ` [PATCH 2/2] net: stmmac: unify mdio functions Corentin Labbe
2016-12-03 20:24 ` David Miller
2016-12-02 8:44 ` [PATCH 1/2] net: stmmac: avoid Camelcase naming Giuseppe CAVALLARO
2016-12-02 8:58 ` Corentin Labbe
2016-12-02 9:25 ` Giuseppe CAVALLARO [this message]
2016-12-03 20:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf5823f-97b4-a9d5-19b5-8b4ef63f52a4@st.com \
--to=peppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=clabbe.montjoie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).