From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15146351C24 for ; Mon, 27 Apr 2026 15:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305509; cv=none; b=t3HFKAhAqD2T6+Pt7i93pV44Zj2I0hGvi7YMUbAReutj2Naqm3L12eIxX37xhdRgzuYDWMZ0qjaFFk1391nJhpG445dQojvvxAoD4UysDp3NewvAYGgpU9Dty6oPzIT3gWxGPr8RTXnz33WCfg8yjIvm7mrOXEeIHJdydAtk5ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305509; c=relaxed/simple; bh=XfBAsF6tClrrSCbk1gXcv41NveFun1CLm+OPUrnpU4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BFjZivmNkLFYb3H19m/1W8TtO/vV8lYVGH9fy5LEZiPASqHxGJOaCvblzL/meNwq/9CkgidmDrPnItUfSgM6Bi7WCrDHmBZMh4RuBetJnhM9YxcYZGpTfcglg1jj0opQAnTEgiVvVfnYCyu3Q5yFfmTHRItP7WUQrkftqZ/dE4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fa+UEDiK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fa+UEDiK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777305507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HDuNa09IWvsLtfQxm277uKUgt69EWS0YpTX06KhV77M=; b=Fa+UEDiKkmfP2bsTl8kcsOP8NjQXl79M6NBpCyNCyKRgK2xa2wjCB8qjugX8NSyhi78/6C OlEz8gAFGoPicwOJg9ox9o9BjJSANO164M5Zh6exh0FRQmwcEX2zUU+/fZwhSi74cnHbnk 5mt4OrUi1TuRZOBSC0E1Qic9iRrJ748= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-z9vv6BunNjibkGWj_hACDg-1; Mon, 27 Apr 2026 11:58:24 -0400 X-MC-Unique: z9vv6BunNjibkGWj_hACDg-1 X-Mimecast-MFC-AGG-ID: z9vv6BunNjibkGWj_hACDg_1777305500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 957FF1944A8E; Mon, 27 Apr 2026 15:58:16 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.44.48.98]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 491A719560AB; Mon, 27 Apr 2026 15:58:16 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C0F71A8096D; Mon, 27 Apr 2026 17:58:13 +0200 (CEST) Date: Mon, 27 Apr 2026 17:58:13 +0200 From: Corinna Vinschen To: Jacob Keller Cc: Simon Horman , intel-wired-lan@osuosl.org, stable@vger.kernel.org, Jose Ignacio Tornos Martinez , netdev@vger.kernel.org, Corinna Vinschen Subject: Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test Message-ID: Mail-Followup-To: Jacob Keller , Simon Horman , intel-wired-lan@osuosl.org, stable@vger.kernel.org, Jose Ignacio Tornos Martinez , netdev@vger.kernel.org References: <20260421111236.875379-1-vinschen@redhat.com> <20260423185530.GI900403@horms.kernel.org> <30b2fade-2545-4f2b-98ad-c6449512c04e@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <30b2fade-2545-4f2b-98ad-c6449512c04e@intel.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Apr 24 17:37, Jacob Keller wrote: > On 4/24/2026 1:32 AM, Corinna Vinschen wrote: > > On Apr 23 19:55, Simon Horman wrote: > >> On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote: > >>> This is just a simple cleanup fix. Commit 35a2443d0910f ("iavf: Add > >>> waiting for response from PF in set mac") introduced a duplicate > >>> ether_addr_equal() check, so the current code tests the new MAC twice > >>> against the former MAC. > >>> > >>> Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b > >>> ("iavf: fix MAC address setting for VFs when filter is rejected") > >>> > >>> Signed-off-by: Corinna Vinschen > >>> Fixes: 35a2443d0910f ("iavf: Add waiting for response from PF in set mac") > >>> Reviewed-by: Aleksandr Loktionov > >>> --- > >>> Added CC: stable@vger.kernel.org > >> > >> Hi, > >> > >> This feels more like a cleanup for net-next (without a Fixes tag) > >> than a fix for net. I'm missing where the bug is here. > > > > Yeah, it's not a bug, the "Fixes" tag was just supposed to point out the > > patch introducing the duplicate test. > > > > Shall I create a v3 or is it ok as is and just goes to net-next instead > > of net? > > > > > > Thanks, > > Corinna > > > > I can make a note for later and either myself or Tony can forward it > net-next as part of an Intel Wired LAN update when the merge window > re-opens and any testing has completed. (Not that there is much needing > to be tested in this patches case) That's nice, thank you! Corinna