From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ayyappan Veeraiyan" Subject: Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters... Date: Tue, 3 Jul 2007 15:01:24 -0700 Message-ID: References: <20070702214238.GA7085@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Jeff Garzik" , netdev@vger.kernel.org, "Kok, Auke-jan H" , arjan@linux.intel.com, akpm@linux-foundation.org To: "Christoph Hellwig" , "Stephen Hemminger" Return-path: Received: from py-out-1112.google.com ([64.233.166.181]:18244 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbXGCWBZ (ORCPT ); Tue, 3 Jul 2007 18:01:25 -0400 Received: by py-out-1112.google.com with SMTP id u77so3503911pyb for ; Tue, 03 Jul 2007 15:01:24 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 7/2/07, Veeraiyan, Ayyappan wrote: > On 7/2/07, Christoph Hellwig wrote: > The submitted driver code supports single queue version in case of MSIX > allocation failures... As I said in the other mail, I feel, restricting > to single Rx queue in NAPI mode is better approach till Stephen's and > DaveM' work of separating NAPI from netdevice is done.. > > > Lots of drivers where the interface name is assigned after request_irq > > just use an internal name, e.g. ixgbeX in the case of this driver. > > Actually looking closer, we don't need to worry about interface name change after request_irq. This driver calls request_irq only on interface up. If interface is up, kernel (dev.c) doesn't allow the name change. So it is a non-issue for this driver. Ayyappan