From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D5F547DD57 for ; Tue, 5 May 2026 14:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777992611; cv=none; b=EPD2LdWupnas/L80UeKOBVWRC3I6fSOh/YLqnXHyFTkV2wd1RS/FOKw1X1E2VGl7X337PTpymQjzYo59njL9BE/OBWJT2eNFzjdse1/MuUJv4ua0m/UBCo+NSCy1e9tu7S6NFRyC16jgmYGI/gb9U4hdUOLtXhezrfI2TVVDBUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777992611; c=relaxed/simple; bh=/ThHF8hJw+I5T6qQTw/Q1CJUS1knLMz9fJpBGnuPP7I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ahj92drkCefPzYDJCIk8/8AsZOIS6CEiX0KO4Di9B3XZGGgOo5a8i2m4PPF65ktJCuiyy+jArX3inAkwWbMk8dFmq1JnSoN6O4/jRexmsUYdHXCr/L/diJnCFoGybvnE9l/ebpnddlSWXq9eVZzfOmHnXZAEgEAkH9U8scymRy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l/9FEifz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HYfOPbc8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l/9FEifz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HYfOPbc8" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 645ESkJR1186937 for ; Tue, 5 May 2026 14:50:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KBSnO8fLfv2V7HIGkj9CawV0Uw7GLfZNqY6E6hFC104=; b=l/9FEifzdbjK9Knf VYMr3kcwzNNLhbAzkKvw0GYs2OJ7sGEeOZWHWKf0cK+obbOnyvKMJDrIQJ8lgoHV XU/JcwvsxKjYVEKjIGZuOVpxLX4NZmGktmosZokNx+YJqslTQBCiGGl9BCYdMXNE crE7L0LpAeXm5vmofh7Uggtr3DCHMeTSJtLFDz6DF2o4nJfDx6jsKCqBo1yrq0Jy rqamtvs6nhXmQIdnBDGtNhhFEDzHZ0fsjdc6/iAFVW2wmae8RcSCd8kJi5+jxz5F c8fmALkBNzOLw+891xaprdQssFDUYsd3Hx7I5HqJ9STd75ldyI54mKNtTm1wzK9E wtw6lQ== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvvgcw60-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 14:50:08 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-1309f4ee96dso2949026c88.1 for ; Tue, 05 May 2026 07:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777992607; x=1778597407; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KBSnO8fLfv2V7HIGkj9CawV0Uw7GLfZNqY6E6hFC104=; b=HYfOPbc86IkFt32OydKGHNPuFrJhwRBtktawwqQaL7c+EwDKjquwu1Nyfu4zfnyZZ+ LKuOVbPuGhWk8PkIk4FQLc4XJkqLBiSb/6+oKDCRJO1nUf1rRB3wJRc/v70wBRRgF9DN iSVh7qluczutqvfo49cFDgf2Wz1lIfLhGgt7anZasKbS1/LTjTUFjx2jK36v4tmJw6Ez 37ahNZZYuKLmU1b9fyeb6hZOdAWCo5JJVOTt/emCyUSI1X3RhiKqbN2MymwCQvG1UfTy +I0/XzR6GoghJrUAswzo09bzPtargiq16SBaOR8Tm6AIg4rFQc8rullqQrhkI0rRDcDX GNhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777992607; x=1778597407; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KBSnO8fLfv2V7HIGkj9CawV0Uw7GLfZNqY6E6hFC104=; b=ipD1NDsBenuZ7ENtaPx+lLImuR0xLAlpNC5IaQq2OX8JPBnH9ogZgC88Gvo96olH98 kKibIXhaT3ebaouGiMl1D+gQAxWc8CnXLFz2CoDy1ptMTQ4+dRdDXXVSs0riVfKF0UrW MCr3bwhPtgr9LovhrtwyW7k8hH1QX3h4quS39JwcmZCzqx+NfuXyeC75fwnaPomeXzGL Ij4WAkv9LamTejd1mUMSA+2I8yeDXEfWq3TwqJ4cIbH27XJlHxE4Ie4vhQ7Pvf0NWU3y 9gq8fN0OFkByXYdMjS8OnP3IEK00869n4dqnlT1ToUciTvc2AjXlYLMUgfxUlagLiJbl v3Eg== X-Forwarded-Encrypted: i=1; AFNElJ9QVk2OKzCVLhExprGZlCVFHJA7VacXVK+jTsQJkbg432Wp0SQZSsrjHHngVNtZDCJ/d+LZ4C0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyoc6nAYZhGvu2fnkrHnPvIBew6J7zxOXkTGjWMEULYRgwOZWHq RuP/JYN4ZZ2htilRBOQyynYmsbm0xuftIbqFvSdM7vpBrBVPPrr986Enf9ncy/AVN1x+577O7ZR T8YlcVvFjCRFpxx1L9lft30vVitG84trSeK16PP3iA7Bd2gm7M1rDKBr09UI= X-Gm-Gg: AeBDiet6uTDPu0KEQNKDECA6v9cda40gBLnEUGo4/QVvMwcyM0+e7G/bWv+OIYLFlG/ 4vaq39MLxGczW6RDNyU6xE20bez6g0Nt483L9q11SbXTptfYkjFrmhj0DTiJEdQhLLjwJzN/vnd pxS2B4Q92pBh0nti8rY4xDWwghnvA5HUkS+jW9BQc5uE5R00quh82kaR5T9HFLUttMxZEgCWECw JOdsf1+Ht3FoIWjPyFywAuOVzhHAk9ccNWGo9fN5FaxjirzVDSwBCGkQ34N1hskLXH2m7ksFgG5 bSS7F+2Xatu+y47OmF8nf0+rWvuAf4Y6HIvwRW74a26gwAhtDj54Hnv9MPv2f2CHmkuCp5oScPE 8SZ5wpDM4lccNNLpneGhDFs8ZMzlXGP1ZPOoLHuah9Ly9h4yo+xZI1dtZNwCXV8/bopORGZ2iFH 2ce6NY5GwzkcUW63nS X-Received: by 2002:a05:7022:6628:b0:122:33e:6d41 with SMTP id a92af1059eb24-12dfd84327fmr6504979c88.23.1777992607382; Tue, 05 May 2026 07:50:07 -0700 (PDT) X-Received: by 2002:a05:7022:6628:b0:122:33e:6d41 with SMTP id a92af1059eb24-12dfd84327fmr6504928c88.23.1777992606769; Tue, 05 May 2026 07:50:06 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df8279e57sm19149584c88.3.2026.05.05.07.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 07:50:05 -0700 (PDT) Message-ID: Date: Tue, 5 May 2026 07:50:03 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 14/16] wifi: ath12k: Switch to generic PAS TZ APIs To: Sumit Garg , andersson@kernel.org, konradybcio@kernel.org, Sowmiya Sree Elavalagan Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg References: <20260504130603.1474043-1-sumit.garg@kernel.org> <20260504130603.1474043-15-sumit.garg@kernel.org> <3bfdc11c-115f-45ab-b0ab-75ad88dc6f31@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <3bfdc11c-115f-45ab-b0ab-75ad88dc6f31@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Aak_i86-9CafpF8eN84LBlpPBfs94ET- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDE0MSBTYWx0ZWRfX+vNWcbpdCPQr zHVzUoSN8fC5Rvg+v3879TyG/Y+BSZ2ItmZlFnY4zlOLbmIy0hzb0tSJFPzcFJlmfv1tDM3pcuF OtxPwTjZr1FBPnhx0pAYTjKw13XzpFuvR0BDvubnh4f6JgxyXO1qldMSjepbiyI8ppms/WaUgBK eYngagYFZok8X+ic1QCddf5XeME03def3yxedaBEz35xsVtwhMeRC3JEPqi+QEMxvwrYlaS4r78 0Cn8jK8mHa/RsvMBCh9FWOru89Yj1VS0E4prbS/M9eqs4HUd4RwUPsnJSCx5EAe8+xLbHGAwt1+ tDbQnnQ75IoMeQB30LzOZ5Bf/l/8jDarCHhGwpC1pYN5lxTz+3nzTw8Jp6/75w07nP3jfBfBUJC GF04dCvsaRYciwQ/yqT2Vxloog/GBfdINkXwwfXgqQKzOWlRUlBJ2CBNdXSduH9U5DK8HBYWnd4 XV9siWpfiM9vVKY6Z1w== X-Authority-Analysis: v=2.4 cv=K+AS2SWI c=1 sm=1 tr=0 ts=69fa03a0 cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VMT16xk1LGalzlQIQqAA:9 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-GUID: Aak_i86-9CafpF8eN84LBlpPBfs94ET- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050141 On 5/5/2026 7:27 AM, Jeff Johnson wrote: > On 5/4/2026 6:06 AM, Sumit Garg wrote: >> @@ -485,9 +485,9 @@ static void ath12k_ahb_power_down(struct ath12k_base *ab, bool is_suspend) >> pasid = (u32_encode_bits(ab_ahb->userpd_id, ATH12K_USERPD_ID_MASK)) | >> ATH12K_AHB_UPD_SWID; >> /* Release the firmware */ >> - ret = qcom_scm_pas_shutdown(pasid); >> + ret = qcom_pas_shutdown(pasid); >> if (ret) >> - ath12k_err(ab, "scm pas shutdown failed for userPD%d\n", >> + ath12k_err(ab, "pas shutdown failed for userPD%d: %d\n", >> ab_ahb->userpd_id); > > at some point the "ret" param was dropped, and this now generates build warnings The 'ret' param was dropped by: 8fb66931fe31 ("wifi: ath12k: Enable IPQ5424 WiFi device support") Not sure if that was on purpose or accidental. Sowmiya? - if (ret) - ath12k_err(ab, "scm pas shutdown failed for userPD%d: %d\n", - ab_ahb->userpd_id, ret); ... + if (ret) + ath12k_err(ab, "scm pas shutdown failed for userPD%d\n", + ab_ahb->userpd_id);