From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f66.google.com ([209.85.215.66]:38354 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbeBZSU3 (ORCPT ); Mon, 26 Feb 2018 13:20:29 -0500 Received: by mail-lf0-f66.google.com with SMTP id i80so4323220lfg.5 for ; Mon, 26 Feb 2018 10:20:29 -0800 (PST) Subject: Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse() To: Stephen Hemminger Cc: netdev@vger.kernel.org, dsahern@gmail.com References: <1519304526-18848-1-git-send-email-serhe.popovych@gmail.com> <1519304526-18848-9-git-send-email-serhe.popovych@gmail.com> <20180226100638.789a770d@xeon-e3> From: Serhey Popovych Message-ID: Date: Mon, 26 Feb 2018 20:20:21 +0200 MIME-Version: 1.0 In-Reply-To: <20180226100638.789a770d@xeon-e3> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Hem9YdRv70XXGxkt04yZNkGPgWCjvUJ6v" Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hem9YdRv70XXGxkt04yZNkGPgWCjvUJ6v Content-Type: multipart/mixed; boundary="mYQWlD2mOqnEG3fpYceQxH29Ktfr6V7x9"; protected-headers="v1" From: Serhey Popovych To: Stephen Hemminger Cc: netdev@vger.kernel.org, dsahern@gmail.com Message-ID: Subject: Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse() References: <1519304526-18848-1-git-send-email-serhe.popovych@gmail.com> <1519304526-18848-9-git-send-email-serhe.popovych@gmail.com> <20180226100638.789a770d@xeon-e3> In-Reply-To: <20180226100638.789a770d@xeon-e3> --mYQWlD2mOqnEG3fpYceQxH29Ktfr6V7x9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Stephen Hemminger wrote: > On Thu, 22 Feb 2018 15:02:06 +0200 > Serhey Popovych wrote: >=20 >> +struct iplink_parse_args { >> + const char *dev; >> + const char *name; >> + const char *type; >> + >> + /* This definitely must be the last one and initialized >> + * by the caller of iplink_parse() that will initialize rest. >> + */ >> + struct iplink_req *req; >> +}; >> + >=20 > No control block please. Accepted. > If you have too many arguments, then that means you need to do > some refactoring. So using structure as single argument to a function isn't an option? >=20 --mYQWlD2mOqnEG3fpYceQxH29Ktfr6V7x9-- --Hem9YdRv70XXGxkt04yZNkGPgWCjvUJ6v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJalE/qAAoJEBTawMmQ61bBqigH/R6p5oQTjdf/6BvojWhCsrt6 anwXoI7DEfrf/UFYlIepjNn0Zf5YYHEYSQAAxE4aXDQbKnPzVph+yzyelt9e1uHj /L7Os54FrfeO+xxgdl3k9TvykfmykE/BF1zjziYdfovrKeg/B7KO6kVt4IsTlfqH uIeiFt8kkqupvMucog3j6/MMMvfyHnH3bmXqmOmmsK5UJ+7/tGDhNzwQ/hv+Lm57 cFTj/blDYyn2A5n600uvWJ3KCTazlN+egb1qA2M2QEXIfI8qCzp2goMM54Nkdxn+ I20HH2yzBdzplvoCFq8U9f1BtwCSzOyOw1raANJdj2no4OnFunN/8RH78XGwllI= =6mcI -----END PGP SIGNATURE----- --Hem9YdRv70XXGxkt04yZNkGPgWCjvUJ6v--