From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C957BA34 for ; Tue, 23 Sep 2025 08:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758616350; cv=none; b=QeOPgp+lR+PIIXuT0sGerlQoLcSjv0PgwVP1nP6Y52jjCLyLu/ABmKKpFen6IhgBVpFC3j9283N2T0s7ARcQgMwJgBk28DlR3+go1e101TMJMlAmBn4AMWfg3LjjfnDG+X+61hq3y27+RNVXzCX0vZzznFcIwqFC5sCz2iS+rzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758616350; c=relaxed/simple; bh=NiZilVO952t8xhzkfD3k2tB4t5QzfJ5IvxtJx2lENi0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kgh2xQU3C77aSUW3fTrHAk8Qr4ldsID45ITcZbmwZ0SxYuVocV5syXDV8Zgo5zccIMan/IOLsAIEB5EcHpufQhqWtWQPFTnYzspaRKwiF9zjMhsaJ5fT+TvMJ2z/CDxwZWYcER9wNWlVc0wDFBf3WepwtQ66zbFc+7HaSpmuT4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GBUjPX4Q; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GBUjPX4Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758616347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AofCBIF9FsjYV+UgMxZqWzFMIGGZG+5eyuxtGxpb2KA=; b=GBUjPX4QfcKVkLivVduw5rOxE3cCbhPEVDuJuuiYKXJjWNl+0YABEs6kUhRVSPp8+H+c/Z i/v22SuTheLKU5cwRUMfcBe9ZdKIFqTDijLoEHimKRkMsBVlq1mKkUnjN+83rxSew35vx/ 8HN05gnhYKN4fPldrdSXwBMYFyPr068= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-yoqiy1I4MQG0C_6MjOFMMw-1; Tue, 23 Sep 2025 04:32:25 -0400 X-MC-Unique: yoqiy1I4MQG0C_6MjOFMMw-1 X-Mimecast-MFC-AGG-ID: yoqiy1I4MQG0C_6MjOFMMw_1758616345 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3f7b5c27d41so943896f8f.0 for ; Tue, 23 Sep 2025 01:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758616344; x=1759221144; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AofCBIF9FsjYV+UgMxZqWzFMIGGZG+5eyuxtGxpb2KA=; b=HAf0HlNrMQmT8bft9kUaJQP3BIhMu4AH6pNRqlX/LInJK5TzoVagzbT5uJ0EqvB34e WuzAhlfQbPuNmz5yGzvnDWLsLW5tw+KQuURx9yaoy/6gyoM2N8baHqtWxH1bAPdN2/Ku J5TUVjbHNFGXjw5HxtxRUw5cbgSyIddhB+6faJyj/zWSCGVHIQbk0LswuOX4ui9VoNCT wMnR5rEmvB2ER36hA3GcJ4YVAspoviK0rmxMc2edkHwKCOM0b8rOLoTgyVROZs2v+MPr S44ZNtQX+1q+r9v66PTkbmZsGhdqeaU2RjBtLnBPLmxWUeH+dHwgjwFyrN8qrl3/faAk GHOQ== X-Forwarded-Encrypted: i=1; AJvYcCXBZ3hl3EDQON1Jc9JzrzpVcC9uxzadqNl8a6p0u5Dxv2d77XwTA0l30jTdBuNToDVYWbmgHMA=@vger.kernel.org X-Gm-Message-State: AOJu0YyMitULkst6cdiKdFODp5/yZefj0hZJ5njMDRkRqXmqfDq6uB7w KBvfL7vEf8b2tlLVI13ZIUjaaQ42LWIPy5G5Rw+nrqhXCKStDrLOnCEtODFf51AhKtluw+yuFdM lPiHAlBYR1jJ5oHazE+RbDF9Ljt8fpv2G1CrNIGzDjj92w3txnEUgSoIExg== X-Gm-Gg: ASbGncviuhsy4BIcev0f9benp9BjELTjE2HCC80E7QpF2lAnJ8ZW1rw7o+UrdPGxSmI ZSyx6NJJIcgkeg/b8XuSM90dpuivJ0ggc/b7CCI2QVwOp7qW1jEHE1WtyDwFYLgQ+stkaAQZ3TB PhRhBh4LZLdk2PQnCt/CrUgw5Y5VDwaLXORyc8Z8ROhRDIcsvO3wQg+PRwUT5Vbtxh/jCdou4Qr 90WQMaY+lsd83UPoHYgDEdutHfQt8GBxYoPO3KA1bVrGLDKa0jfCCA30uTRmuVLNQzp+vkF/XWe CN4bajZugs7qKenFQidBdyLtAbf8LFR7qeNxnHuq8lCSiNeGlXBaxIimDEbjHmvbI8DEWZEVhdb mrCu05Im3/xUS X-Received: by 2002:a05:6000:2484:b0:3fd:7388:28a with SMTP id ffacd0b85a97d-405cb3e57efmr1100211f8f.8.1758616344538; Tue, 23 Sep 2025 01:32:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNRhUtcGLLr4h24SLafmawf/1r1TuWen0JWEexdyB4FM711uxWMVzCfOmriGj/xPN14FiEAg== X-Received: by 2002:a05:6000:2484:b0:3fd:7388:28a with SMTP id ffacd0b85a97d-405cb3e57efmr1100193f8f.8.1758616344066; Tue, 23 Sep 2025 01:32:24 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-464f0aac271sm231480095e9.3.2025.09.23.01.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Sep 2025 01:32:23 -0700 (PDT) Message-ID: Date: Tue, 23 Sep 2025 10:32:22 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 net 2/2] selftests: bonding: add ipsec offload test To: Hangbin Liu , netdev@vger.kernel.org Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Shuah Khan , Petr Machata , linux-kselftest@vger.kernel.org References: <20250918020202.440904-1-liuhangbin@gmail.com> <20250918020202.440904-2-liuhangbin@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250918020202.440904-2-liuhangbin@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/18/25 4:02 AM, Hangbin Liu wrote: > diff --git a/tools/testing/selftests/drivers/net/bonding/bond_ipsec_offload.sh b/tools/testing/selftests/drivers/net/bonding/bond_ipsec_offload.sh > new file mode 100755 > index 000000000000..4b19949a4c33 > --- /dev/null > +++ b/tools/testing/selftests/drivers/net/bonding/bond_ipsec_offload.sh > @@ -0,0 +1,154 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-2.0 > + > +# IPsec over bonding offload test: > +# > +# +----------------+ > +# | bond0 | > +# | | | > +# | eth0 eth1 | > +# +---+-------+----+ > +# > +# We use netdevsim instead of physical interfaces > +#------------------------------------------------------------------- > +# Example commands > +# ip x s add proto esp src 192.0.2.1 dst 192.0.2.2 \ > +# spi 0x07 mode transport reqid 0x07 replay-window 32 \ > +# aead 'rfc4106(gcm(aes))' 1234567890123456dcba 128 \ > +# sel src 192.0.2.1/24 dst 192.0.2.2/24 > +# offload dev bond0 dir out > +# ip x p add dir out src 192.0.2.1/24 dst 192.0.2.2/24 \ > +# tmpl proto esp src 192.0.2.1 dst 192.0.2.2 \ > +# spi 0x07 mode transport reqid 0x07 > +# > +#------------------------------------------------------------------- > + > +lib_dir=$(dirname "$0") > +source "$lib_dir"/../../../net/lib.sh > +algo="aead rfc4106(gcm(aes)) 0x3132333435363738393031323334353664636261 128" > +srcip=192.0.2.1 > +dstip=192.0.2.2 > +ipsec0=/sys/kernel/debug/netdevsim/netdevsim0/ports/0/ipsec > +ipsec1=/sys/kernel/debug/netdevsim/netdevsim0/ports/1/ipsec > +active_slave="" > + > +active_slave_changed() > +{ > + local old_active_slave=$1 > + local new_active_slave=$(ip -n ${ns} -d -j link show bond0 | \ > + jq -r ".[].linkinfo.info_data.active_slave") shell check is not super happy about the lack of double quotes around the variables (above and many places below) and about declaring the variable and assigning it to a subshell in the same statement. I think it's better to address such warnings for consistency. Thanks, Paolo